Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753899Ab2JMQuh (ORCPT ); Sat, 13 Oct 2012 12:50:37 -0400 Received: from mail.parknet.co.jp ([210.171.160.6]:50348 "EHLO mail.parknet.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753834Ab2JMQug (ORCPT ); Sat, 13 Oct 2012 12:50:36 -0400 From: OGAWA Hirofumi To: Namjae Jeon Cc: akpm@linux-foundation.org, bfields@fieldses.org, viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org, Namjae Jeon , Ravishankar N , Amit Sahrawat Subject: Re: [PATCH v4 3/4] fat (exportfs): rebuild directory-inode if fat_dget() fails References: <1349598764-3252-1-git-send-email-linkinjeon@gmail.com> <877gqu90x1.fsf@devron.myhome.or.jp> <87391i8mny.fsf@devron.myhome.or.jp> Date: Sun, 14 Oct 2012 01:50:31 +0900 In-Reply-To: (Namjae Jeon's message of "Sun, 14 Oct 2012 00:14:43 +0900") Message-ID: <87r4p271uw.fsf@devron.myhome.or.jp> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1282 Lines: 31 Namjae Jeon writes: >>>>> + if (!fat_get_dotdot_entry(child_dir->d_inode, &dotdot_bh, &de)) { >>>>> + parent_logstart = fat_get_start(sbi, de); >>>>> parent_inode = fat_dget(sb, parent_logstart); >>>>> + if (parent_inode || sbi->options.nfs != FAT_NFS_NOSTALE_RO) >>>>> + goto out; >>>>> + if (!parent_logstart) >>>>> + /*logstart of dotdot entry is zero if >>>>> + * if the directory's parent is root >>>>> + */ >>>>> + parent_inode = sb->s_root->d_inode; >>>> >>>> get_parent() should not be called for root dir, right? >>> Yes. >> >> Ah, actual question was - subdir of root can be passed to this? I guess >> it is possible... > Yes, you're right. OK, I think I got where is wrong. If it is the subdir of rootdir, fat_dget() should get the inode of root? So, I guess if parent_logstart == 0, it is BUG(). -- OGAWA Hirofumi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/