Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754405Ab2JNUx7 (ORCPT ); Sun, 14 Oct 2012 16:53:59 -0400 Received: from mail-wi0-f178.google.com ([209.85.212.178]:44114 "EHLO mail-wi0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754036Ab2JNUx5 (ORCPT ); Sun, 14 Oct 2012 16:53:57 -0400 MIME-Version: 1.0 In-Reply-To: References: <87fw5m7ipz.fsf@rustcorp.com.au> From: Linus Torvalds Date: Sun, 14 Oct 2012 13:53:36 -0700 X-Google-Sender-Auth: uLCtLU52ao8D2EKYPbSRfh4m-PA Message-ID: Subject: Re: [PULL] modules To: Rusty Russell Cc: LKML , Alex Lyashkov , Arnd Bergmann , Dan Carpenter , David Howells , "David S. Miller" , Dmitry Kasatkin , Herbert Xu , Josh Boyer , linux-crypto@vger.kernel.org, Lucas De Marchi , Matthew Garrett , Milan Broz , Ralf Baechle , Randy Dunlap , Sam Ravnborg Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1074 Lines: 28 On Sun, Oct 14, 2012 at 1:11 PM, Linus Torvalds wrote: > > I've pulled and resolved the branch, and I'm going through it now, but > I'd like this verified before I push out if it all looks fine.. Hmm. So this thing makes me wonder: /* Not having a signature is only an error if we're strict. */ if (err < 0 && fips_enabled) panic("Module verification failed with error %d in FIPS mode\n", err); do we really want to panic (even in fips_enabled mode)? Sounds like it will just kill the machine if we ever end up having an unsigned module by mistake anywhere. I realize that fips_enabled is only for crazy people, but it's exactly code like this that limits it to only crazy people. Is there some *reason* for this? Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/