Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751577Ab2JOH5U (ORCPT ); Mon, 15 Oct 2012 03:57:20 -0400 Received: from mail.parknet.co.jp ([210.171.160.6]:50787 "EHLO mail.parknet.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751028Ab2JOH5T (ORCPT ); Mon, 15 Oct 2012 03:57:19 -0400 From: OGAWA Hirofumi To: Namjae Jeon Cc: akpm@linux-foundation.org, bfields@fieldses.org, viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org, Namjae Jeon , Ravishankar N , Amit Sahrawat Subject: Re: [PATCH v4 3/4] fat (exportfs): rebuild directory-inode if fat_dget() fails References: <1349598764-3252-1-git-send-email-linkinjeon@gmail.com> <877gqu90x1.fsf@devron.myhome.or.jp> <87391i8mny.fsf@devron.myhome.or.jp> <87r4p271uw.fsf@devron.myhome.or.jp> Date: Mon, 15 Oct 2012 16:57:12 +0900 In-Reply-To: (Namjae Jeon's message of "Mon, 15 Oct 2012 16:28:30 +0900") Message-ID: <87r4p0417r.fsf@devron.myhome.or.jp> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 964 Lines: 24 Namjae Jeon writes: >> OK, I think I got where is wrong. If it is the subdir of rootdir, >> fat_dget() should get the inode of root? > That is correct. Whenever fat_dget() is called for sub-directories > which is in root folder, we assign root inode as parent inode. >> >> So, I guess if parent_logstart == 0, it is BUG(). > Would you explain more why you think it is BUG() ? Because root dentry is never expired until umount. So, fat_dget() shouldn't never fail to get inode for subdir of rootdir. Otherwise, "stale_rw" will not be working in the case even if there is cache. I.e. I think we don't need to check parent_logstart == 0. Thanks. -- OGAWA Hirofumi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/