Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754492Ab2JOTFb (ORCPT ); Mon, 15 Oct 2012 15:05:31 -0400 Received: from mail-wi0-f172.google.com ([209.85.212.172]:33167 "EHLO mail-wi0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751628Ab2JOTFa (ORCPT ); Mon, 15 Oct 2012 15:05:30 -0400 MIME-Version: 1.0 In-Reply-To: <1350042118.24256.93.camel@gandalf.local.home> References: <1349998076-15495-1-git-send-email-dhsharp@google.com> <1349998076-15495-2-git-send-email-dhsharp@google.com> <1350042118.24256.93.camel@gandalf.local.home> From: David Sharp Date: Mon, 15 Oct 2012 12:05:08 -0700 Message-ID: Subject: Re: [PATCH v6 1/6] tracing,x86: Add a TSC trace_clock To: Steven Rostedt Cc: Geert Uytterhoeven , linux-kernel@vger.kernel.org, Masami Hiramatsu , Ingo Molnar , Thomas Gleixner , "H. Peter Anvin" Content-Type: text/plain; charset=UTF-8 X-System-Of-Record: true Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1186 Lines: 29 On Fri, Oct 12, 2012 at 4:41 AM, Steven Rostedt wrote: > On Fri, 2012-10-12 at 07:05 +0200, Geert Uytterhoeven wrote: >> On Fri, Oct 12, 2012 at 1:27 AM, David Sharp wrote: >> > +#include >> >> Please use the Kbuild infrastructure ("generic-y += ..." in >> arch/*/include/asm/Kbuild) >> instead of adding wrappers around the asm-generic version. > > So that's how that's done. Learn something new everyday. Too bad the one > file I checked (div64.h) doesn't seem to do it for ia64 and others. > > Can we please have someone clean up all the archs and remove any *.h > wrappers and use the kbuild infrastructure instead. That way, when > another developer goes to look at how this is done, they wont copy the > wrong method again. (Maybe I'll just do it :-p) > > David, > > Can you just send an update of this one patch. Will do. Thanks for the education, Geert. :) d# -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/