Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754637Ab2JOT4p (ORCPT ); Mon, 15 Oct 2012 15:56:45 -0400 Received: from mail-wg0-f44.google.com ([74.125.82.44]:61328 "EHLO mail-wg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754517Ab2JOT4o (ORCPT ); Mon, 15 Oct 2012 15:56:44 -0400 MIME-Version: 1.0 In-Reply-To: <1350069085-13283-2-git-send-email-stigge@antcom.de> References: <1350069085-13283-1-git-send-email-stigge@antcom.de> <1350069085-13283-2-git-send-email-stigge@antcom.de> Date: Mon, 15 Oct 2012 21:56:43 +0200 Message-ID: Subject: Re: [PATCH RFC 1/6 v3] gpio: Add a block GPIO API to gpiolib From: Linus Walleij To: Roland Stigge Cc: grant.likely@secretlab.ca, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, w.sang@pengutronix.de, jbe@pengutronix.de, plagnioj@jcrosoft.com, highguy@gmail.com, broonie@opensource.wolfsonmicro.com Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 496 Lines: 15 On Fri, Oct 12, 2012 at 9:11 PM, Roland Stigge wrote: > +#define NR_GPIO_BLOCKS 16 > + > +static struct gpio_block *gpio_block[NR_GPIO_BLOCKS]; 16 looks quite arbitrary, as noted elsewhere please use a list. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/