Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753614Ab2JOXkU (ORCPT ); Mon, 15 Oct 2012 19:40:20 -0400 Received: from c60.cesmail.net ([216.154.195.49]:35083 "EHLO c60.cesmail.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751327Ab2JOXkS (ORCPT ); Mon, 15 Oct 2012 19:40:18 -0400 Date: Mon, 15 Oct 2012 19:40:08 -0400 From: Pavel Roskin To: Al Viro Cc: linux-kernel@vger.kernel.org Subject: Re: Bisected regression in Linux 3.7.0-rc1, hang on login caused by replace_fd() Message-ID: <20121015194008.29e38086@mj> In-Reply-To: <20121015232705.GM2616@ZenIV.linux.org.uk> References: <20121015171437.32e9a4ac@mj> <20121015215127.GK2616@ZenIV.linux.org.uk> <20121015191105.2dac4cac@mj> <20121015232705.GM2616@ZenIV.linux.org.uk> X-Mailer: Claws Mail 3.8.1 (GTK+ 2.24.8; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 606 Lines: 18 On Tue, 16 Oct 2012 00:27:05 +0100 Al Viro wrote: > I think I understand what's going on there. Add > fput(files[0]) after that replace_fd(); we have a leak and while > that's not the right way to fix it, that'd verify if anything else is > going on there. Yes, it's working now! No more hang on login! -- Regards, Pavel Roskin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/