Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Mon, 2 Sep 2002 16:30:57 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Mon, 2 Sep 2002 16:30:57 -0400 Received: from mailhost.tue.nl ([131.155.2.5]:3057 "EHLO mailhost.tue.nl") by vger.kernel.org with ESMTP id ; Mon, 2 Sep 2002 16:30:56 -0400 Date: Mon, 2 Sep 2002 22:35:25 +0200 From: Andries Brouwer To: Linus Torvalds Cc: Andries.Brouwer@cwi.nl, neilb@cse.unsw.edu.au, , Subject: Re: PATCH - change to blkdev->queue calling triggers BUG in md.c Message-ID: <20020902203525.GB9328@win.tue.nl> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.3.25i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1272 Lines: 31 On Mon, Sep 02, 2002 at 10:01:46AM -0700, Linus Torvalds wrote: > For example, the higher levels want to do a partition table re-read > if the media really has changed. My original setup made a kernel that does not know anything about partition tables. User space would tell the kernel about partitions on some block device. Roughly speaking the impact is that there is a partx invocation before a mount. Now it seems Al is doing all the work, so I can just sit back and watch. But I hope he makes precisely this: a kernel that does not do any partition reading of its own. Andries [Yes, it is fundamentally wrong when the kernel starts guessing. Guessing filesystem type is bad. Also guessing partition table type is bad. Moreover, the kernel probing may lead to device problems and even to kernel crashes, as I last observed two days ago. Only the user knows what she wants to do with this disk. Format? Remove OnTrack Disk Manager? There are all kinds of situations where partition table re-read is directly harmful.] - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/