Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754894Ab2JPPEp (ORCPT ); Tue, 16 Oct 2012 11:04:45 -0400 Received: from mga02.intel.com ([134.134.136.20]:27105 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754796Ab2JPPEo (ORCPT ); Tue, 16 Oct 2012 11:04:44 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.80,593,1344236400"; d="scan'208";a="228020842" Date: Tue, 16 Oct 2012 23:04:17 +0800 From: Fengguang Wu To: Yuanhan Liu Cc: linux-kernel@vger.kernel.org, Jeff Garzik , Viresh Kumar , linux-ide@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH 1/5] ata: suspend/resume callbacks should be conditionally compiled on CONFIG_PM_SLEEP Message-ID: <20121016150417.GA4379@localhost> References: <1350399545-11179-1-git-send-email-yuanhan.liu@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1350399545-11179-1-git-send-email-yuanhan.liu@linux.intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2469 Lines: 70 // Add CC to PM list On Tue, Oct 16, 2012 at 10:59:01PM +0800, Yuanhan Liu wrote: > This will fix warnings like following when CONFIG_PM_SLEEP is not set: > > warning: 'xxx_suspend' defined but not used [-Wunused-function] > warning: 'xxx_resume' defined but not used [-Wunused-function] > > Because > SET_SYSTEM_SLEEP_PM_OPS(suspend_fn, resume_fn) > > Only references the callbacks on CONFIG_PM_SLEEP (instead of CONFIG_PM). > > Cc: Jeff Garzik > Cc: Viresh Kumar > Cc: linux-ide@vger.kernel.org > Signed-off-by: Yuanhan Liu > Signed-off-by: Fengguang Wu > --- > drivers/ata/ahci_platform.c | 2 +- > drivers/ata/pata_arasan_cf.c | 2 +- > drivers/ata/sata_highbank.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/ata/ahci_platform.c b/drivers/ata/ahci_platform.c > index b1ae480..b7078af 100644 > --- a/drivers/ata/ahci_platform.c > +++ b/drivers/ata/ahci_platform.c > @@ -238,7 +238,7 @@ static int __devexit ahci_remove(struct platform_device *pdev) > return 0; > } > > -#ifdef CONFIG_PM > +#ifdef CONFIG_PM_SLEEP > static int ahci_suspend(struct device *dev) > { > struct ahci_platform_data *pdata = dev_get_platdata(dev); > diff --git a/drivers/ata/pata_arasan_cf.c b/drivers/ata/pata_arasan_cf.c > index 26201eb..3fe2f66 100644 > --- a/drivers/ata/pata_arasan_cf.c > +++ b/drivers/ata/pata_arasan_cf.c > @@ -908,7 +908,7 @@ static int __devexit arasan_cf_remove(struct platform_device *pdev) > return 0; > } > > -#ifdef CONFIG_PM > +#ifdef CONFIG_PM_SLEEP > static int arasan_cf_suspend(struct device *dev) > { > struct ata_host *host = dev_get_drvdata(dev); > diff --git a/drivers/ata/sata_highbank.c b/drivers/ata/sata_highbank.c > index 0d7c4c2..b045b19 100644 > --- a/drivers/ata/sata_highbank.c > +++ b/drivers/ata/sata_highbank.c > @@ -378,7 +378,7 @@ static int __devexit ahci_highbank_remove(struct platform_device *pdev) > return 0; > } > > -#ifdef CONFIG_PM > +#ifdef CONFIG_PM_SLEEP > static int ahci_highbank_suspend(struct device *dev) > { > struct ata_host *host = dev_get_drvdata(dev); > -- > 1.7.7.6 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/