Date: Tue, 16 Oct 2012 16:17:21 -0400 (EDT)
Message-Id: <20121016.161721.460693104731176775.davem@davemloft.net>
To: bhutchings@solarflare.com
Cc: richardcochran@gmail.com, haicheng.li@linux.intel.com,
        netdev@vger.kernel.org, tshimizu818@gmail.com,
        linux-kernel@vger.kernel.org, haicheng.lee@gmail.com
Subject: Re: [PATCH 1/2] Fix build error caused by broken PCH_PTP module
 dependency.
From: David Miller <davem@davemloft.net>
In-Reply-To: <1350418167.2649.47.camel@bwh-desktop.uk.solarflarecom.com>
References: <1349300710.2763.8.camel@bwh-desktop.uk.solarflarecom.com>
	<20121003.204336.1981040659629176119.davem@davemloft.net>
	<1350418167.2649.47.camel@bwh-desktop.uk.solarflarecom.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 944
Lines: 24

From: Ben Hutchings <bhutchings@solarflare.com>
Date: Tue, 16 Oct 2012 21:09:27 +0100

> I think the various kconfig options should be changed as follows:
> 
> 1. Only PTP_1588_CLOCK selects PPS.
> 2. Nothing depends on EXPERIMENTAL.  (This stuff has been in for 18
>    months and it's even being backported to RHEL 6 now.)
> 3. Either:
>    (a) The per-driver PHC options select nothing, and the driver options
>        do e.g.:
> 	select PTP_1588_CLOCK if IGB_PTP
>    (b) The per-driver PHC options are removed and the driver options do:
> 	select PTP_1588_CLOCK
>        (i.e. PHC support is unconditional)
> 
> Any objections to this, or preference for (a) vs (b)?

No objections, prefer (b).
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/