Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755308Ab2JPWPW (ORCPT ); Tue, 16 Oct 2012 18:15:22 -0400 Received: from caramon.arm.linux.org.uk ([78.32.30.218]:53669 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753928Ab2JPWPU (ORCPT ); Tue, 16 Oct 2012 18:15:20 -0400 Date: Tue, 16 Oct 2012 23:15:02 +0100 From: Russell King - ARM Linux To: Kevin Hilman Cc: Thomas Gleixner , linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] genirq: provide means to retrigger parent Message-ID: <20121016221502.GY28061@n2100.arm.linux.org.uk> References: <1350425269-11489-1-git-send-email-khilman@deeprootsystems.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1350425269-11489-1-git-send-email-khilman@deeprootsystems.com> User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1602 Lines: 33 On Tue, Oct 16, 2012 at 03:07:49PM -0700, Kevin Hilman wrote: > From: Thomas Gleixner > > Attempts to retrigger nested threaded IRQs currently fail because they > have no primary handler. In order to support retrigger of nested > IRQs, the parent IRQ needs to be retriggered. > > To fix, when an IRQ needs to be resent, if the interrupt has a parent > IRQ and runs in the context of the parent IRQ, then resend the parent. > > Also, handle_nested_irq() needs to clear the replay flag like the > other handlers, otherwise check_irq_resend() will set it and it will > never be cleared. Without clearing, it results in the first resend > working fine, but check_irq_resend() returning early on subsequent > resends because the replay flag is still set. > > Problem discovered on ARM/OMAP platforms where a nested IRQ that's > also a wakeup IRQ happens late in suspend and needed to be retriggered > during the resume process. > > Reported-by: Kevin Hilman > Tested-by: Kevin Hilman > [khilman@ti.com: changelog edits, clear IRQS_REPLAY in handle_nested_irq()] > Signed-off-by: Thomas Gleixner Umm, we also have the converse situation. We have platforms where the resend has to be done from the child IRQ, and the parent must not be touched. I hope that doesn't break those. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/