Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755547Ab2JPWpW (ORCPT ); Tue, 16 Oct 2012 18:45:22 -0400 Received: from mail-qc0-f174.google.com ([209.85.216.174]:45197 "EHLO mail-qc0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754864Ab2JPWpV convert rfc822-to-8bit (ORCPT ); Tue, 16 Oct 2012 18:45:21 -0400 MIME-Version: 1.0 In-Reply-To: <20121016071136.GB5172@kroah.com> References: <20121015235836.GA3214@kroah.com> <1350347562-32643-1-git-send-email-arve@android.com> <20121016071136.GB5172@kroah.com> Date: Tue, 16 Oct 2012 15:45:20 -0700 Message-ID: Subject: Re: [PATCH 1/2] Staging: android: binder: Fix memory leak on thread/process exit From: =?ISO-8859-1?Q?Arve_Hj=F8nnev=E5g?= To: Greg KH Cc: xiaobing.tu@intel.com, ccross@android.com, davej@redhat.com, akpm@linux-foundation.org, mingo@elte.hu, rusty@rustcorp.com.au, a.p.zijlstra@chello.nl, linux-kernel@vger.kernel.org, rostedt@goodmis.org, di.zhang@intel.com, xindong.ma@intel.com, alex.zuo@intel.com Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1359 Lines: 32 On Tue, Oct 16, 2012 at 12:11 AM, Greg KH wrote: > On Mon, Oct 15, 2012 at 05:32:41PM -0700, Arve Hj?nnev?g wrote: >> If a thread or process exited while a reply, one-way transaction or >> death notification was pending, the struct holding the pending work >> was leaked. >> >> Change-Id: I2eaafaba1c0ecda3ec0872d449dc16d0721c21e7 > > What is this field? Please don't include this in kernel patches, it > forces me to edit the patch by hand :( > It is a tag generated a git hook to uniquely identify a change through multiple revisions of that change. If the tag does not already exist the hook adds it. I removed it from the reposted patches as you requested, but have you considered leaving it in? It is a useful search token both for finding different revisions of a patch and for finding which branch a change has been cherry-picked into. > Also, this should go to older kernels, right? It can, but the leak is relatively slow so I don't think it is critical. I looked at one device that had been running for a while and it had leaked around 16k per month. -- Arve Hj?nnev?g -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/