Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755894Ab2JQALs (ORCPT ); Tue, 16 Oct 2012 20:11:48 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:61840 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755759Ab2JQALr (ORCPT ); Tue, 16 Oct 2012 20:11:47 -0400 Date: Tue, 16 Oct 2012 17:11:42 -0700 From: Tejun Heo To: Daisuke Nishimura Cc: LKML , cgroups , Ben Blum , Li Zefan Subject: Re: [REGRESSION] cgroup: notify_on_release may not be triggered in some cases Message-ID: <20121017001142.GN16166@google.com> References: <20121004163716.64dae034dab9eafa2b6e6a8f@mxp.nes.nec.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20121004163716.64dae034dab9eafa2b6e6a8f@mxp.nes.nec.co.jp> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1398 Lines: 43 Hello, On Thu, Oct 04, 2012 at 04:37:16PM +0900, Daisuke Nishimura wrote: > notify_on_release must be triggered when the last process in a cgroup is > move to another. But if the first(and only) process in a cgroup is moved to > another, notify_on_release is not triggered. > > # mkdir /cgroup/cpu/SRC > # mkdir /cgroup/cpu/DST > # > # echo 1 >/cgroup/cpu/SRC/notify_on_release > # echo 1 >/cgroup/cpu/DST/notify_on_release > # > # sleep 300 & > [1] 8629 > # > # echo 8629 >/cgroup/cpu/SRC/tasks > # echo 8629 >/cgroup/cpu/DST/tasks > -> notify_on_release for /SRC must be triggered at this point, > but it isn't. > > This is because put_css_set() is called before setting CGRP_RELEASABLE > in cgroup_task_migrate(), and is a regression introduce by the > commit:74a1166d(cgroups: make procs file writable), which was merged > into v3.0. > > Cc: Ben Blum > Cc: Tejun Heo > Cc: Li Zefan > Cc: # v3.0.x and later > Signed-off-by: Daisuke Nishimura Applied to cgroup/for-3.7-fixes w/ Li's ack added. Thanks! -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/