Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756138Ab2JQDgR (ORCPT ); Tue, 16 Oct 2012 23:36:17 -0400 Received: from mga09.intel.com ([134.134.136.24]:3600 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755690Ab2JQDgP convert rfc822-to-8bit (ORCPT ); Tue, 16 Oct 2012 23:36:15 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.80,597,1344236400"; d="scan'208";a="228514178" From: "Liu, Chuansheng" To: Yinghai Lu CC: "tglx@linutronix.de" , "mingo@redhat.com" , "Siddha, Suresh B" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] x86/ioapic: fix the irq_2_pin mem leak when destroy_irq Thread-Topic: [PATCH] x86/ioapic: fix the irq_2_pin mem leak when destroy_irq Thread-Index: AQHNrAuC4qnOuCFjlUW0E781HzncsZe8164A Date: Wed, 17 Oct 2012 03:36:12 +0000 Message-ID: <27240C0AC20F114CBF8149A2696CBE4A1A18B9@SHSMSX101.ccr.corp.intel.com> References: <1350468706.15558.26.camel@cliu38-desktop-build> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1479 Lines: 44 > -----Original Message----- > From: yhlu.kernel@gmail.com [mailto:yhlu.kernel@gmail.com] On Behalf Of > Yinghai Lu > Sent: Wednesday, October 17, 2012 10:03 AM > To: Liu, Chuansheng > Cc: tglx@linutronix.de; mingo@redhat.com; Siddha, Suresh B; > linux-kernel@vger.kernel.org > Subject: Re: [PATCH] x86/ioapic: fix the irq_2_pin mem leak when destroy_irq > > On Wed, Oct 17, 2012 at 3:11 AM, Chuansheng Liu > wrote: > > > > When destroying the irq, before free cfg, need to check > > cfg->irq_2_pin and free it when it is not NULL. > > > > Signed-off-by: liu chuansheng > > --- > > i had that in another patch... > > https://lkml.org/lkml/2012/2/23/574 Sorry to not know that. > > ---- > Subject [PATCH 01/13] x86, irq: Convert irq_2_pin list to generic list > Date Thu, 23 Feb 2012 19:48:47 -0800 > > So we can use generic list helper function. Does it really need the generic list with both prev and next pointers? For irq_2_pin list, the next pointer seems be enough. > > Also make free_irq_cfg() free irq_2_pin list. > ---- > > http://git.kernel.org/?p=linux/kernel/git/yinghai/linux-yinghai.git;a=commitdiff; > h=4010f4dbd1b172e3080d3e6c459a58c4b575f081 > > Yinghai -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/