Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751501Ab2JQEFu (ORCPT ); Wed, 17 Oct 2012 00:05:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33420 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750798Ab2JQEFs (ORCPT ); Wed, 17 Oct 2012 00:05:48 -0400 Date: Wed, 17 Oct 2012 00:05:15 -0400 From: Dave Jones To: David Rientjes Cc: Andrew Morton , Linus Torvalds , KOSAKI Motohiro , bhutchings@solarflare.com, Konstantin Khlebnikov , Naoya Horiguchi , Hugh Dickins , KAMEZAWA Hiroyuki , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [patch for-3.7] mm, mempolicy: fix printing stack contents in numa_maps Message-ID: <20121017040515.GA13505@redhat.com> Mail-Followup-To: Dave Jones , David Rientjes , Andrew Morton , Linus Torvalds , KOSAKI Motohiro , bhutchings@solarflare.com, Konstantin Khlebnikov , Naoya Horiguchi , Hugh Dickins , KAMEZAWA Hiroyuki , linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20121008150949.GA15130@redhat.com>

MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3326 Lines: 70 On Tue, Oct 16, 2012 at 05:31:23PM -0700, David Rientjes wrote: > - pol = get_vma_policy(proc_priv->task, vma, vma->vm_start); > + task_lock(task); > + pol = get_vma_policy(task, vma, vma->vm_start); > mpol_to_str(buffer, sizeof(buffer), pol, 0); > mpol_cond_put(pol); > + task_unlock(task); This seems to cause some fallout for me.. BUG: sleeping function called from invalid context at kernel/mutex.c:269 in_atomic(): 1, irqs_disabled(): 0, pid: 8558, name: trinity-child2 3 locks on stack by trinity-child2/8558: #0: held: (&p->lock){+.+.+.}, instance: ffff88010c9a00b0, at: [] seq_lseek+0x3f/0x120 #1: held: (&mm->mmap_sem){++++++}, instance: ffff88013956f7c8, at: [] m_start+0xa7/0x190 #2: held: (&(&p->alloc_lock)->rlock){+.+...}, instance: ffff88011fc64f30, at: [] show_numa_map+0x14f/0x610 Pid: 8558, comm: trinity-child2 Not tainted 3.7.0-rc1+ #32 Call Trace: [] __might_sleep+0x14c/0x200 [] mutex_lock_nested+0x2e/0x50 [] mpol_shared_policy_lookup+0x33/0x90 [] shmem_get_policy+0x33/0x40 [] get_vma_policy+0x3a/0x90 [] show_numa_map+0x163/0x610 [] ? pid_maps_open+0x20/0x20 [] ? pagemap_hugetlb_range+0xf0/0xf0 [] show_pid_numa_map+0x13/0x20 [] traverse+0xf2/0x230 [] seq_lseek+0xab/0x120 [] sys_lseek+0x7b/0xb0 [] tracesys+0xe1/0xe6 same problem, different syscall.. BUG: sleeping function called from invalid context at kernel/mutex.c:269 in_atomic(): 1, irqs_disabled(): 0, pid: 21996, name: trinity-child3 3 locks on stack by trinity-child3/21996: #0: held: (&p->lock){+.+.+.}, instance: ffff88008d712c08, at: [] seq_read+0x3d/0x3e0 #1: held: (&mm->mmap_sem){++++++}, instance: ffff88013956f7c8, at: [] m_start+0xa7/0x190 #2: held: (&(&p->alloc_lock)->rlock){+.+...}, instance: ffff88011fc64f30, at: [] show_numa_map+0x14f/0x610 Pid: 21996, comm: trinity-child3 Not tainted 3.7.0-rc1+ #32 Call Trace: [] __might_sleep+0x14c/0x200 [] mutex_lock_nested+0x2e/0x50 [] mpol_shared_policy_lookup+0x33/0x90 [] shmem_get_policy+0x33/0x40 [] get_vma_policy+0x3a/0x90 [] show_numa_map+0x163/0x610 [] ? pid_maps_open+0x20/0x20 [] ? pagemap_hugetlb_range+0xf0/0xf0 [] show_pid_numa_map+0x13/0x20 [] traverse+0xf2/0x230 [] seq_read+0x34b/0x3e0 [] ? seq_lseek+0x120/0x120 [] do_loop_readv_writev+0x5a/0x90 [] do_readv_writev+0x1c1/0x1e0 [] ? get_parent_ip+0x11/0x50 [] vfs_readv+0x35/0x60 [] sys_preadv+0xc2/0xe0 [] tracesys+0xe1/0xe6 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/