Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756055Ab2JQGey (ORCPT ); Wed, 17 Oct 2012 02:34:54 -0400 Received: from mga03.intel.com ([143.182.124.21]:4416 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753149Ab2JQGex (ORCPT ); Wed, 17 Oct 2012 02:34:53 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.80,597,1344236400"; d="scan'208";a="205444971" From: "Tc, Jenny" To: "myungjoo.ham@samsung.com" , "cw00.choi@samsung.com" CC: "linux-kernel@vger.kernel.org" , anish kumar Subject: RE: [PATCH] extcon : callback function to read cable property Thread-Topic: [PATCH] extcon : callback function to read cable property Thread-Index: AQHNpqL6iLZgSIxMH0GKmzwm7ve2K5eyQk0AgAEKtWCAAHd6AIAJUHGg Date: Wed, 17 Oct 2012 06:34:47 +0000 Message-ID: <20ADAB092842284E95860F279283C5643BA10D@BGSMSX101.gar.corp.intel.com> References: <1349864628-21479-1-git-send-email-jenny.tc@intel.com> <1349880328.22926.2.camel@anish-Inspiron-N5050> <20ADAB092842284E95860F279283C56439BC4A@BGSMSX101.gar.corp.intel.com> <1349963260.8329.1.camel@anish-Inspiron-N5050> In-Reply-To: <1349963260.8329.1.camel@anish-Inspiron-N5050> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.223.10.10] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id q9H6Z0Le002427 Content-Length: 1632 Lines: 37 Myunjoo/Chanwoo Ping... Could you please review this patch? -jtc > > > Subject: Re: [PATCH] extcon : callback function to read cable > > > property > > > > > > I think the reason why we have extcon is in first place is to only > > > notify the clients of cable connection and disconnection and it is > > > up to the client to decide what else to do with the cable such as > > > finding which state it is in and other details. > > > So I feel this should not be handled in the extcon. > > > > > > However it is up to the maintainer to decide. > > > > Once the consumer gets the notification, it needs to take some action. > > One of the action is to read the cable properties. This can be done by > > proprietary calls which is known both to the consumer and the provider. > > My intention is to avoid this proprietary calls. Since both the > > provider and consumer are communicating with the extcon subsystem , I > > feel having a callback function of this kind would help to avoid the > > use of proprietary calls. Also I agree that extcon notifier chains are > > used to notify the cable state (attach/detach). But if a cable has > > more than two states (like the charger cable) how do we support it without > having a callback function like this? > > Let the maintainer take the final decision. > Well this use case will keep on growing if we start factor in this kind of > changes and that is why I am opposed to adding any other state. > Maintainer? > > > > > ????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?