Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756639Ab2JQLHH (ORCPT ); Wed, 17 Oct 2012 07:07:07 -0400 Received: from mail4.hitachi.co.jp ([133.145.228.5]:48797 "EHLO mail4.hitachi.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756022Ab2JQLHF (ORCPT ); Wed, 17 Oct 2012 07:07:05 -0400 X-AuditID: b753bd60-96850ba000002f78-81-507e9155d23d X-AuditID: b753bd60-96850ba000002f78-81-507e9155d23d Message-ID: <507E914E.50100@hitachi.com> Date: Wed, 17 Oct 2012 20:06:54 +0900 From: Masami Hiramatsu Organization: Hitachi, Ltd., Japan User-Agent: Mozilla/5.0 (Windows NT 5.2; rv:13.0) Gecko/20120614 Thunderbird/13.0.1 MIME-Version: 1.0 To: Hyeoncheol Lee Cc: acme@ghostprotocols.net, LKML , Srikar Dronamraju , "yrl.pp-manager.tt@hitachi.com" Subject: Re: [PATCH] perf probe: convert_name_to_addr() allocated the wrong size buffers for names References: <1350462496-20035-1-git-send-email-hyc.lee@gmail.com> In-Reply-To: <1350462496-20035-1-git-send-email-hyc.lee@gmail.com> Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: AAAAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2501 Lines: 79 (2012/10/17 17:28), Hyeoncheol Lee wrote: > The function allocated wrong size buffers for names > > Cc: Masami Hiramatsu > Cc: Srikar Dronamraju > Signed-off-by: Hyeoncheol Lee > --- > tools/perf/util/probe-event.c | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c > index 49a256e..5cd7c42 100644 > --- a/tools/perf/util/probe-event.c > +++ b/tools/perf/util/probe-event.c > @@ -2273,6 +2273,8 @@ int show_available_funcs(const char *target, struct strfilter *_filter, > return available_user_funcs(target); > } > Please add a comment like below on the code. /* * sizeof(type) * 2 returns the maximum length of hexadecimal number * of type, because each half byte is encoding in one hex character. * Another 3 bytes are for "0x" and null character. */ Others are OK for me :) Thanks! > +#define MAX_ADDRNAME_LEN (3 + sizeof(unsigned long long) * 2) > + > /* > * uprobe_events only accepts address: > * Convert function and any offset to address > @@ -2332,7 +2334,7 @@ static int convert_name_to_addr(struct perf_probe_event *pev, const char *exec) > if (!pev->group) { > char *ptr1, *ptr2, *exec_copy; > > - pev->group = zalloc(sizeof(char *) * 64); > + pev->group = zalloc(sizeof(char) * 64); > exec_copy = strdup(exec); > if (!exec_copy) { > ret = -ENOMEM; > @@ -2352,14 +2354,15 @@ static int convert_name_to_addr(struct perf_probe_event *pev, const char *exec) > free(exec_copy); > } > free(pp->function); > - pp->function = zalloc(sizeof(char *) * MAX_PROBE_ARGS); > + pp->function = zalloc(sizeof(char) * MAX_ADDRNAME_LEN); > if (!pp->function) { > ret = -ENOMEM; > pr_warning("Failed to allocate memory by zalloc.\n"); > goto out; > } > - e_snprintf(pp->function, MAX_PROBE_ARGS, "0x%llx", vaddr); > - ret = 0; > + ret = e_snprintf(pp->function, MAX_ADDRNAME_LEN, "0x%llx", vaddr); > + if (ret > 0) > + ret = 0; > > out: > if (map) { > -- Masami HIRAMATSU IT Management Research Dept. Linux Technology Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: masami.hiramatsu.pt@hitachi.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/