Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756708Ab2JQMFf (ORCPT ); Wed, 17 Oct 2012 08:05:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:10356 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751132Ab2JQMFe (ORCPT ); Wed, 17 Oct 2012 08:05:34 -0400 Date: Wed, 17 Oct 2012 14:05:25 +0200 (CEST) From: =?ISO-8859-15?Q?Luk=E1=A8_Czerner?= X-X-Sender: lukas@dhcp-1-104.brq.redhat.com To: Adil Mujeeb cc: tytso@mit.edu, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 01/10] ext4: balloc: Fixed coding style issue In-Reply-To: <1350414785-7848-1-git-send-email-mujeeb.adil@gmail.com> Message-ID: References: <1350414785-7848-1-git-send-email-mujeeb.adil@gmail.com> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2606 Lines: 70 On Wed, 17 Oct 2012, Adil Mujeeb wrote: > Date: Wed, 17 Oct 2012 00:42:56 +0530 > From: Adil Mujeeb > To: tytso@mit.edu, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, > linux-kernel@vger.kernel.org > Cc: Adil Mujeeb > Subject: [PATCH 01/10] ext4: balloc: Fixed coding style issue > > Fixed checkpatch.pl reported ERRORs Hi Adil, let me ask you something. How useful do you think those changes are ? Have you learned anything by creating those patches ? Just to clarify why I am asking such weird questions. It's not one of those sneer questions, I would really like to know. Thanks! -Lukas > > Signed-off-by: Adil Mujeeb > --- > linux-3.7-rc1/fs/ext4/balloc.c | 8 ++++---- > 1 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/linux-3.7-rc1/fs/ext4/balloc.c b/linux-3.7-rc1/fs/ext4/balloc.c > index 1b50890..395418d 100644 > --- a/linux-3.7-rc1/fs/ext4/balloc.c > +++ b/linux-3.7-rc1/fs/ext4/balloc.c > @@ -246,7 +246,7 @@ unsigned ext4_free_clusters_after_init(struct super_block *sb, > * @bh: pointer to the buffer head to store the block > * group descriptor > */ > -struct ext4_group_desc * ext4_get_group_desc(struct super_block *sb, > +struct ext4_group_desc *ext4_get_group_desc(struct super_block *sb, > ext4_group_t block_group, > struct buffer_head **bh) > { > @@ -700,7 +700,7 @@ static unsigned long ext4_bg_num_gdb_nometa(struct super_block *sb, > if (!ext4_bg_has_super(sb, group)) > return 0; > > - if (EXT4_HAS_INCOMPAT_FEATURE(sb,EXT4_FEATURE_INCOMPAT_META_BG)) > + if (EXT4_HAS_INCOMPAT_FEATURE(sb, EXT4_FEATURE_INCOMPAT_META_BG)) > return le32_to_cpu(EXT4_SB(sb)->s_es->s_first_meta_bg); > else > return EXT4_SB(sb)->s_gdb_count; > @@ -721,11 +721,11 @@ unsigned long ext4_bg_num_gdb(struct super_block *sb, ext4_group_t group) > le32_to_cpu(EXT4_SB(sb)->s_es->s_first_meta_bg); > unsigned long metagroup = group / EXT4_DESC_PER_BLOCK(sb); > > - if (!EXT4_HAS_INCOMPAT_FEATURE(sb,EXT4_FEATURE_INCOMPAT_META_BG) || > + if (!EXT4_HAS_INCOMPAT_FEATURE(sb, EXT4_FEATURE_INCOMPAT_META_BG) || > metagroup < first_meta_bg) > return ext4_bg_num_gdb_nometa(sb, group); > > - return ext4_bg_num_gdb_meta(sb,group); > + return ext4_bg_num_gdb_meta(sb, group); > > } > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/