Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932357Ab2JQTpU (ORCPT ); Wed, 17 Oct 2012 15:45:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:4505 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752794Ab2JQTpT (ORCPT ); Wed, 17 Oct 2012 15:45:19 -0400 Date: Wed, 17 Oct 2012 15:45:01 -0400 From: Dave Jones To: David Rientjes Cc: Andrew Morton , Linus Torvalds , KOSAKI Motohiro , bhutchings@solarflare.com, Konstantin Khlebnikov , Naoya Horiguchi , Hugh Dickins , KAMEZAWA Hiroyuki , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [patch for-3.7] mm, mempolicy: fix printing stack contents in numa_maps Message-ID: <20121017194501.GA24400@redhat.com> Mail-Followup-To: Dave Jones , David Rientjes , Andrew Morton , Linus Torvalds , KOSAKI Motohiro , bhutchings@solarflare.com, Konstantin Khlebnikov , Naoya Horiguchi , Hugh Dickins , KAMEZAWA Hiroyuki , linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20121017040515.GA13505@redhat.com> <20121017181413.GA16805@redhat.com> <20121017193229.GC16805@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1072 Lines: 26 On Wed, Oct 17, 2012 at 12:38:55PM -0700, David Rientjes wrote: > > > Sounds good. Is it possible to verify that policy_cache isn't getting > > > larger than normal in /proc/slabinfo, i.e. when all processes with a > > > task mempolicy or shared vma policy have exited, are there still a > > > significant number of active objects? > > > > Killing the fuzzer caused it to drop dramatically. > > > Excellent, thanks. This shows that the refcounting is working properly > and we're not leaking any references as a result of this change causing > the mempolicies to never be freed. ("numa_policy" turns out to be > policy_cache in the code, so thanks for checking both of them.) > > Could I add your tested-by? Sure. Here's a fresh one I just baked. Tested-by: Dave Jones Dave -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/