Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757420Ab2JQU3H (ORCPT ); Wed, 17 Oct 2012 16:29:07 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:35666 "EHLO out3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756440Ab2JQU3D (ORCPT ); Wed, 17 Oct 2012 16:29:03 -0400 X-Sasl-enc: uu6eg5Jzf5oEMHvAfvrNFhWCyAkPnF0mMsYjvrfpIHqU 1350505741 Date: Wed, 17 Oct 2012 13:29:00 -0700 From: Greg Kroah-Hartman To: Borislav Petkov Cc: Tony Luck , "Naveen N. Rao" , LKML , Borislav Petkov Subject: Re: [PATCH 1/5] drivers/base: Add a DEVICE_BOOL_ATTR macro Message-ID: <20121017202900.GA30907@kroah.com> References: <1350472435-29307-1-git-send-email-bp@amd64.org> <1350472435-29307-2-git-send-email-bp@amd64.org> <20121017190300.GB25996@kroah.com> <20121017201018.GC32230@aftab.osrc.amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20121017201018.GC32230@aftab.osrc.amd.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1418 Lines: 39 On Wed, Oct 17, 2012 at 10:10:18PM +0200, Borislav Petkov wrote: > On Wed, Oct 17, 2012 at 12:03:00PM -0700, Greg Kroah-Hartman wrote: > > On Wed, Oct 17, 2012 at 01:13:51PM +0200, Borislav Petkov wrote: > > > +ssize_t device_store_bool(struct device *dev, struct device_attribute *attr, > > > + const char *buf, size_t size) > > > +{ > > > + struct dev_ext_attribute *ea = to_ext_attr(attr); > > > + u8 bval; > > > + > > > + if (kstrtou8(buf, 10, &bval) < 0) > > > + return -EINVAL; > > > + > > > + *(bool *)ea->var = !!bval; > > > + > > > + return size; > > > +} > > > +EXPORT_SYMBOL_GPL(device_store_bool); > > > > Wouldn't it be nice to be able to accept 'y' 'Y' 'n' 'N' '0' and '1' > > like the module bool parameter code does? That would make things a bit > > more consistent, and possibly allow you to use this function for the > > module sysfs file handling as well. > > That could be easily done, let me try it tomorrow. Any other letters you > prefer? Maybe, 'G' 'r' 'e' 'g'... ? Heh, no, but that would be funny :) Take the function already from the module code, it should be reusable, if not, it would be a good idea to make it so. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/