Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753749Ab2JRC0w (ORCPT ); Wed, 17 Oct 2012 22:26:52 -0400 Received: from mail-bk0-f46.google.com ([209.85.214.46]:40375 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752030Ab2JRC0u (ORCPT ); Wed, 17 Oct 2012 22:26:50 -0400 MIME-Version: 1.0 In-Reply-To: <20121018022530.GB24939@gmail.com> References: <1349863655-29320-1-git-send-email-zwu.kernel@gmail.com> <1349863655-29320-10-git-send-email-zwu.kernel@gmail.com> <20121016002744.GC2864@dastard> <20121018022530.GB24939@gmail.com> Date: Thu, 18 Oct 2012 10:26:48 +0800 Message-ID: Subject: Re: [RFC v3 09/13] vfs: add one wq to update map info periodically From: Zhi Yong Wu To: Zhi Yong Wu , Dave Chinner , linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, linuxram@linux.vnet.ibm.com, viro@zeniv.linux.org.uk, dave@jikos.cz, tytso@mit.edu, cmm@us.ibm.com, Zhi Yong Wu Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1412 Lines: 43 On Thu, Oct 18, 2012 at 10:25 AM, Zheng Liu wrote: > On Wed, Oct 17, 2012 at 02:34:15PM +0800, Zhi Yong Wu wrote: >> >> diff --git a/fs/hot_tracking.h b/fs/hot_tracking.h >> >> index d19e64a..7a79a6d 100644 >> >> --- a/fs/hot_tracking.h >> >> +++ b/fs/hot_tracking.h >> >> @@ -36,6 +36,9 @@ >> >> */ >> >> #define TIME_TO_KICK 400 >> >> >> >> +/* set how often to update temperatures (seconds) */ >> >> +#define HEAT_UPDATE_DELAY 400 >> > >> > FWIW, 400 seconds is an unusual time period. It's expected that >> > periodic work might take place at intervals of 5 minutes, 10 >> > minutes, etc, not 6m40s. It's much easier to predict and understand >> > behaviour if it's at a interval of whole units like minutes, >> > especially when looking at timestamped event traces. Hence 300s (5 >> > minutes) makes a lot more sense as a period for updates... >> got it. thanks. > > Hi Zhi Yong, > > IMHO we'd better to make this value parameterized, and then the user > can adjust this value dynamically. Yeah, this has been in my TODO list. But i want to make the core function can work at first. > > Regards, > Zheng -- Regards, Zhi Yong Wu -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/