Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754064Ab2JREmJ (ORCPT ); Thu, 18 Oct 2012 00:42:09 -0400 Received: from ozlabs.org ([203.10.76.45]:48427 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751496Ab2JREmE (ORCPT ); Thu, 18 Oct 2012 00:42:04 -0400 From: Rusty Russell To: mtk.manpages@gmail.com Cc: Kees Cook , Andrew Morton , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-man , Lucas De Marchi , Jon Masters Subject: Re: [PATCH] init_module: update to modern interfaces In-Reply-To: References: <20120920232737.GA2953@www.outflux.net> <87wqyx7me7.fsf@rustcorp.com.au> User-Agent: Notmuch/0.13.2 (http://notmuchmail.org) Emacs/23.3.1 (i686-pc-linux-gnu) Date: Thu, 18 Oct 2012 14:44:36 +1030 Message-ID: <87fw5co1qr.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1641 Lines: 54 "Michael Kerrisk (man-pages)" writes: > Hi Rusty, > > Thanks for the review! One open question below. > > On Thu, Oct 11, 2012 at 4:50 AM, Rusty Russell wrote: >> "Michael Kerrisk (man-pages)" writes: >>> [CC widened, so that some more review might come in. Rusty?] >> >> Sure. >> >> Looks good. but: >> >>> .B EBUSY >>> The module's initialization routine failed. >> >> Possibly. You should mention that the individual module's >> initialization routine can return other errors as appropriate. > > Done! > > In fact, the existing EBUSY text seems completely bogus. Should it not > read something like > "Timeout while trying to resolve a symbol reference by this module."? Yes, indeed. >>> .BR EINVAL " (Linux 2.4 and earlier)" >>> Some >>> .I image >>> slot is filled in incorrectly, >>> .I image\->name >>> does not correspond to the original module name, some >>> .I image\->deps >>> entry does not correspond to a loaded module, >>> or some other similar inconsistency. >>> .TP >> >> Why document this? > > Because the general approach in man-pages is to document past as well > as current behavior. Since there are few user-space customers of > init_module(), perhaps you are right that this is unnecessary. I > dropped it. It was just that you didn't refer to the old structure anywhere else... Thanks, Rusty. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/