Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753336Ab2JRIB0 (ORCPT <rfc822;w@1wt.eu>);
	Thu, 18 Oct 2012 04:01:26 -0400
Received: from youngberry.canonical.com ([91.189.89.112]:54734 "EHLO
	youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750906Ab2JRIBX (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 18 Oct 2012 04:01:23 -0400
Message-ID: <507FB74F.1010104@canonical.com>
Date: Thu, 18 Oct 2012 01:01:19 -0700
From: John Johansen <john.johansen@canonical.com>
Organization: Canonical
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121010 Thunderbird/16.0.1
MIME-Version: 1.0
To: Hiromu Yakura <hiromu1996@gmail.com>
CC: linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org,
        James Morris <james.l.morris@oracle.com>
Subject: Re: [PATCH] AppArmor: Modify Makefile to avoid Oops
References: <38590271.RTeeX2bDYV@hiromu-macbook>
In-Reply-To: <38590271.RTeeX2bDYV@hiromu-macbook>
X-Enigmail-Version: 1.4.5
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1219
Lines: 34

On 10/18/2012 12:19 AM, Hiromu Yakura wrote:
> In my environment, AppArmor cause Oops every time when cupsd launch.
> 
> This is the log of Oops:
> [  114.876511] general protection fault: 0000 [#1] SMP 

<snip>

> It seems that bad address was passed for the second argument of 
> audit_log_untrustedstring() at audit_cb() in capability.c:
>  52     audit_log_untrustedstring(ab, capability_names[sa->u.cap]);
> 
> The array "capability_names" is defined in capability_names.h but the content 
> of this is generated by Makefile from include/linux/capability.h
> However, capability.h was moved to include/uapi/linux/capability.h and because 
> of this, the array is empty.
> That's why, sa->u.cap become out of range this and segmentation fault caused.
> 
> Let's fix it.
> 
> Cc: James Morris <james.l.morris@oracle.com>
> Cc: John Johansen <john.johansen@canonical.com>
> 
Thanks Hiromu,

but this was fixed a few hours ago
http://marc.info/?t=135050396600008&r=1&w=2


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/