Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755569Ab2JRNde (ORCPT ); Thu, 18 Oct 2012 09:33:34 -0400 Received: from smtp.ctxuk.citrix.com ([62.200.22.115]:25919 "EHLO SMTP.EU.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755064Ab2JRNdc (ORCPT ); Thu, 18 Oct 2012 09:33:32 -0400 X-IronPort-AV: E=Sophos;i="4.80,607,1344211200"; d="scan'208";a="15255715" Message-ID: <1350567209.2460.145.camel@zakaz.uk.xensource.com> Subject: Re: [PATCH 5/6] xen: arm: implement remap interfaces needed for privcmd mappings. From: Ian Campbell To: Stefano Stabellini CC: Konrad Rzeszutek Wilk , Mukesh Rathor , "linux-kernel@vger.kernel.org" , "xen-devel@lists.xen.org" Date: Thu, 18 Oct 2012 14:33:29 +0100 In-Reply-To: References: <1350473518.2460.58.camel@zakaz.uk.xensource.com> <1350473532-15863-5-git-send-email-ian.campbell@citrix.com> Organization: Citrix Systems, Inc. Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.4.3-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 972 Lines: 29 On Thu, 2012-10-18 at 14:27 +0100, Stefano Stabellini wrote: > On Wed, 17 Oct 2012, Ian Campbell wrote: > > We use XENMEM_add_to_physmap_range which is the preferred interface > > for foreign mappings. > > > > Signed-off-by: Ian Campbell > > It looks OK but there are few code style issues, please run the patch > through checkpatch. The only one I get is: WARNING: please, no spaces at the start of a line #83: FILE: include/xen/interface/memory.h:175: + uint16_t size;$ total: 0 errors, 1 warnings, 64 lines checked The prevailing indentation in that file is 4 spaces so I think we should ignore the warning in this case in the interests of consistency with the surrounding code. Ian. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/