Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756789Ab2JRPxo (ORCPT ); Thu, 18 Oct 2012 11:53:44 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:57056 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756466Ab2JRPxn (ORCPT ); Thu, 18 Oct 2012 11:53:43 -0400 MIME-Version: 1.0 In-Reply-To: <1350574699-6419-1-git-send-email-ming.lei@canonical.com> References: <1350574699-6419-1-git-send-email-ming.lei@canonical.com> Date: Thu, 18 Oct 2012 23:53:41 +0800 Message-ID: Subject: Re: [PATCH] lib/dma-debug.c: fix __hash_bucket_find From: Ming Lei To: linux-kernel@vger.kernel.org Cc: Ming Lei , Joerg Roedel , Shuah Khan , Paul Gortmaker , Andrew Morton , Jakub Kicinski Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1970 Lines: 65 Hi, Below v1 should be more efficient and simper, sorry for the noise. Thanks, -- Ming Lei -- >From d275d195794ff80e018145f2fae714b35ddc49e2 Mon Sep 17 00:00:00 2001 From: Ming Lei Date: Thu, 18 Oct 2012 23:30:57 +0800 Subject: [PATCH v1] lib/dma-debug.c: fix __hash_bucket_find If there is only one match, the unique matched entry should be returned. Without the fix, the commit f62566214fe31c9f9b3218a42f1b19e6a9e6844a dma-debug: new interfaces to debug dma mapping errors can't work reliably because only device and dma_addr are passed to dma_mapping_error(). Cc: Joerg Roedel Cc: Shuah Khan Cc: Paul Gortmaker Cc: Andrew Morton Cc: Jakub Kicinski Signed-off-by: Ming Lei --- lib/dma-debug.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/dma-debug.c b/lib/dma-debug.c index 94aa94e..59f4a1a 100644 --- a/lib/dma-debug.c +++ b/lib/dma-debug.c @@ -277,7 +277,7 @@ static struct dma_debug_entry *__hash_bucket_find(struct hash_bucket *bucket, match_fn match) { struct dma_debug_entry *entry, *ret = NULL; - int matches = 0, match_lvl, last_lvl = 0; + int matches = 0, match_lvl, last_lvl = -1; list_for_each_entry(entry, &bucket->list, list) { if (!match(ref, entry)) @@ -306,7 +306,7 @@ static struct dma_debug_entry *__hash_bucket_find(struct hash_bucket *bucket, } else if (match_lvl > last_lvl) { /* * We found an entry that fits better then the - * previous one + * previous one or it is the 1st match. */ last_lvl = match_lvl; ret = entry; -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/