Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755595Ab2JRV6N (ORCPT ); Thu, 18 Oct 2012 17:58:13 -0400 Received: from mail-pa0-f46.google.com ([209.85.220.46]:44600 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753268Ab2JRV6M (ORCPT ); Thu, 18 Oct 2012 17:58:12 -0400 Date: Thu, 18 Oct 2012 14:58:07 -0700 From: Tejun Heo To: Michal Hocko Cc: linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Li Zefan , Johannes Weiner , KAMEZAWA Hiroyuki , Balbir Singh Subject: Re: [PATCH 2/6] memcg: root_cgroup cannot reach mem_cgroup_move_parent Message-ID: <20121018215807.GO13370@google.com> References: <1350480648-10905-1-git-send-email-mhocko@suse.cz> <1350480648-10905-3-git-send-email-mhocko@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1350480648-10905-3-git-send-email-mhocko@suse.cz> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 751 Lines: 21 On Wed, Oct 17, 2012 at 03:30:44PM +0200, Michal Hocko wrote: > The root cgroup cannot be destroyed so we never hit it idown the > mem_cgroup_pre_destroy path and mem_cgroup_force_empty_write shouldn't > even try to do anything if called for the root. > > This means that mem_cgroup_move_parent doesn't have to bother with the > root cgroup and it can assume it can always move charges upwards. > > Signed-off-by: Michal Hocko Reviewed-by: Tejun Heo Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/