Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932246Ab2JRWhT (ORCPT ); Thu, 18 Oct 2012 18:37:19 -0400 Received: from mail-bk0-f46.google.com ([209.85.214.46]:44619 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752080Ab2JRWhR (ORCPT ); Thu, 18 Oct 2012 18:37:17 -0400 MIME-Version: 1.0 In-Reply-To: <1350568765-5723-1-git-send-email-weiyang@linux.vnet.ibm.com> References: <1350568765-5723-1-git-send-email-weiyang@linux.vnet.ibm.com> Date: Fri, 19 Oct 2012 00:37:15 +0200 Message-ID: Subject: Re: [PATCH] remove untouched code in kfifo_in From: richard -rw- weinberger To: Wei Yang Cc: linux-kernel@vger.kernel.org, stefani@seibold.net, jkosina@suse.cz Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 699 Lines: 18 On Thu, Oct 18, 2012 at 3:59 PM, Wei Yang wrote: > In kfifo_in marco, one piece of code is arounded by if(0). This code in > introduced by Stefani Seibold to suppress a compiler > warning. This warning is not there with the upgrade of gcc version. > > This patch just remove this code. Are you sure? This code fragment looks like a compiler bomb to detect type mismatch to me... -- Thanks, //richard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/