Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030486Ab2JSDFh (ORCPT ); Thu, 18 Oct 2012 23:05:37 -0400 Received: from mail.kernel.org ([198.145.19.201]:52009 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964790Ab2JSCsi (ORCPT ); Thu, 18 Oct 2012 22:48:38 -0400 From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Greg Kroah-Hartman , alan@lxorguk.ukuu.org.uk, Christoph Hellwig , Nicholas Bellinger Subject: [ 19/76] iscsit: remove incorrect unlock in iscsit_build_sendtargets_resp Date: Thu, 18 Oct 2012 19:46:43 -0700 Message-Id: <20121019024353.192954526@linuxfoundation.org> X-Mailer: git-send-email 1.8.0.rc0.18.gf84667d In-Reply-To: <20121019024350.087156547@linuxfoundation.org> References: <20121019024350.087156547@linuxfoundation.org> User-Agent: quilt/0.60-2.1.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1139 Lines: 37 3.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Christoph Hellwig commit 904753da183566c71211d23c169a80184648c121 upstream. Fix a potential multiple spin-unlock -> deadlock scenario during the overflow check within iscsit_build_sendtargets_resp() as found by sparse static checking. Signed-off-by: Christoph Hellwig Signed-off-by: Nicholas Bellinger Signed-off-by: Greg Kroah-Hartman --- drivers/target/iscsi/iscsi_target.c | 1 - 1 file changed, 1 deletion(-) --- a/drivers/target/iscsi/iscsi_target.c +++ b/drivers/target/iscsi/iscsi_target.c @@ -3271,7 +3271,6 @@ static int iscsit_build_sendtargets_resp len += 1; if ((len + payload_len) > buffer_len) { - spin_unlock(&tiqn->tiqn_tpg_lock); end_of_buf = 1; goto eob; } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/