Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932117Ab2JSFYC (ORCPT ); Fri, 19 Oct 2012 01:24:02 -0400 Received: from www84.your-server.de ([213.133.104.84]:43751 "EHLO www84.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752390Ab2JSFYA (ORCPT ); Fri, 19 Oct 2012 01:24:00 -0400 Message-ID: <1350624189.14741.1.camel@wall-e> Subject: Re: [PATCH] remove untouched code in kfifo_in From: Stefani Seibold To: richard -rw- weinberger Cc: Wei Yang , linux-kernel@vger.kernel.org, jkosina@suse.cz Date: Fri, 19 Oct 2012 07:23:09 +0200 In-Reply-To: References: <1350568765-5723-1-git-send-email-weiyang@linux.vnet.ibm.com> Content-Type: text/plain; charset="ISO-8859-15" X-Mailer: Evolution 3.4.4 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Authenticated-Sender: stefani@seibold.net Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 864 Lines: 21 Am Freitag, den 19.10.2012, 00:37 +0200 schrieb richard -rw- weinberger: > On Thu, Oct 18, 2012 at 3:59 PM, Wei Yang wrote: > > In kfifo_in marco, one piece of code is arounded by if(0). This code in > > introduced by Stefani Seibold to suppress a compiler > > warning. This warning is not there with the upgrade of gcc version. > > > > This patch just remove this code. > > Are you sure? > This code fragment looks like a compiler bomb to detect type mismatch to me... > Yes, you are great! That was the reason why i made this peace of code. So don't remove it! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/