Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757067Ab2JSGCy (ORCPT ); Fri, 19 Oct 2012 02:02:54 -0400 Received: from mail-ie0-f174.google.com ([209.85.223.174]:46467 "EHLO mail-ie0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757021Ab2JSGCx (ORCPT ); Fri, 19 Oct 2012 02:02:53 -0400 MIME-Version: 1.0 In-Reply-To: <20121019055943.GA4185@localhost.localdomain> References: <1350559712-8514-1-git-send-email-shiraz.hashim@st.com> <20121019055943.GA4185@localhost.localdomain> Date: Fri, 19 Oct 2012 11:32:51 +0530 Message-ID: Subject: Re: [PATCH] pwm: add spear pwm driver support From: Viresh Kumar To: Shiraz Hashim Cc: thierry.reding@avionic-design.de, spear--sw-devel@lists.codex.cro.st.com, linux-kernel@vger.kernel.org, spear-devel@list.st.com Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 596 Lines: 18 On 19 October 2012 11:29, Shiraz Hashim wrote: >> > + clk_disable_unprepare(pc->clk); >> >> call only disable from here. Leave it prepared for ever. >> > > and unprepare only in _remove. Okay. yes. > I need to shut down all active pwms, how else would you suggest that ? I misread the code. Leave this comment. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/