Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758125Ab2JSJKs (ORCPT ); Fri, 19 Oct 2012 05:10:48 -0400 Received: from mx2.parallels.com ([64.131.90.16]:42946 "EHLO mx2.parallels.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753881Ab2JSJKo (ORCPT ); Fri, 19 Oct 2012 05:10:44 -0400 Message-ID: <50811903.9000105@parallels.com> Date: Fri, 19 Oct 2012 13:10:27 +0400 From: Glauber Costa User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121009 Thunderbird/16.0 MIME-Version: 1.0 To: David Rientjes CC: Andrew Morton , , , Mel Gorman , Tejun Heo , Michal Hocko , Johannes Weiner , , Christoph Lameter , Pekka Enberg , , , Pekka Enberg Subject: Re: [PATCH v5 06/14] memcg: kmem controller infrastructure References: <1350382611-20579-1-git-send-email-glommer@parallels.com> <1350382611-20579-7-git-send-email-glommer@parallels.com> <20121017151214.e3d2aa3b.akpm@linux-foundation.org> <507FC8E3.8020006@parallels.com> In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1001 Lines: 23 On 10/19/2012 02:06 AM, David Rientjes wrote: > On Thu, 18 Oct 2012, Glauber Costa wrote: > >>> Do we actually need to test PF_KTHREAD when current->mm == NULL? >>> Perhaps because of aio threads whcih temporarily adopt a userspace mm? >> >> I believe so. I remember I discussed this in the past with David >> Rientjes and he advised me to test for both. >> > > PF_KTHREAD can do use_mm() to assume an ->mm but hopefully they aren't > allocating slab while doing so. Have you considered actually charging > current->mm->owner for that memory, though, since the kthread will have > freed the memory before unuse_mm() or otherwise have charged it on behalf > of a user process, i.e. only exempting PF_KTHREAD? > I always charge current->mm->owner. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/