Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758171Ab2JSJLW (ORCPT ); Fri, 19 Oct 2012 05:11:22 -0400 Received: from hqemgate03.nvidia.com ([216.228.121.140]:6379 "EHLO hqemgate03.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752152Ab2JSJLT (ORCPT ); Fri, 19 Oct 2012 05:11:19 -0400 X-PGP-Universal: processed; by hqnvupgp05.nvidia.com on Fri, 19 Oct 2012 02:11:18 -0700 Message-ID: <5081190D.50200@nvidia.com> Date: Fri, 19 Oct 2012 14:40:37 +0530 From: Laxman Dewangan User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101208 Thunderbird/3.1.7 MIME-Version: 1.0 To: Stephen Warren , Vinod Koul CC: "linux@arm.linux.org.uk" , "linux-tegra@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 2/5] ARM: tegra: dts: add slink controller dt entry References: <1350557795-31487-1-git-send-email-ldewangan@nvidia.com> <1350557795-31487-3-git-send-email-ldewangan@nvidia.com> <50808595.8070505@wwwdotorg.org> In-Reply-To: <50808595.8070505@wwwdotorg.org> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1809 Lines: 52 On Friday 19 October 2012 04:11 AM, Stephen Warren wrote: > On 10/18/2012 04:56 AM, Laxman Dewangan wrote: >> Add slink controller details in the dts file of >> Tegra20 and Tegra30. >> diff --git a/arch/arm/boot/dts/tegra20.dtsi b/arch/arm/boot/dts/tegra20.dtsi >> + slink@7000d400 { >> + compatible = "nvidia,tegra20-slink"; >> + reg =<0x7000d400 0x200>; >> + interrupts =<0 59 0x04>; >> + nvidia,dma-req-sel =<15>; > I thought the common DT DMA bindings were going to be in 3.7, and hence > we could just use them here rather than inventing another custom > property for this purpose? Adding Vinod here. I looked the dma devicetree bingind document and did not found the generic binding name. Howvere, for arm-pl330.txt, it is explained as Example: pdma0: pdma@12680000 { compatible = "arm,pl330", "arm,primecell"; reg = <0x12680000 0x1000>; interrupts = <99>; }; Client drivers (device nodes requiring dma transfers from dev-to-mem or mem-to-dev) should specify the DMA channel numbers using a two-value pair as shown below. [property name] = <[phandle of the dma controller] [dma request id]>; where 'dma request id' is the dma request number which is connected to the client controller. The 'property name' is recommended to be of the form -dma-channel. Example: tx-dma-channel = <&pdma0 12>; So here I can also add the name like same. Vinod, Do you see any issue in follow the above mechanism for Tegra dma client driver? Thanks, Laxman -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/