Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758519Ab2JSMbl (ORCPT ); Fri, 19 Oct 2012 08:31:41 -0400 Received: from mail-ia0-f174.google.com ([209.85.210.174]:65131 "EHLO mail-ia0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752671Ab2JSMbk (ORCPT ); Fri, 19 Oct 2012 08:31:40 -0400 MIME-Version: 1.0 In-Reply-To: References: <1350600107-4558-1-git-send-email-elezegarcia@gmail.com> Date: Fri, 19 Oct 2012 09:31:39 -0300 Message-ID: Subject: Re: [PATCH 1/3] mm/slob: Drop usage of page->private for storing page-sized allocations From: Ezequiel Garcia To: David Rientjes Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Tim Bird , Pekka Enberg , Matt Mackall Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1010 Lines: 28 On Thu, Oct 18, 2012 at 7:46 PM, David Rientjes wrote: > On Thu, 18 Oct 2012, Ezequiel Garcia wrote: > >> This field was being used to store size allocation so it could be >> retrieved by ksize(). However, it is a bad practice to not mark a page >> as a slab page and then use fields for special purposes. >> There is no need to store the allocated size and >> ksize() can simply return PAGE_SIZE << compound_order(page). >> >> Cc: Pekka Penberg > > Is Pekka Penberg the long distant cousin of Pekka Enberg? :) You should > probably cc the author of slob, Matt Mackall , on slob > patches. > Ouch! ;-) I found another typo so I'll just re-send the whole patchset. Thanks for the review! Ezequiel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/