Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756448Ab2JSNMZ (ORCPT ); Fri, 19 Oct 2012 09:12:25 -0400 Received: from acsinet15.oracle.com ([141.146.126.227]:22353 "EHLO acsinet15.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753548Ab2JSNMX (ORCPT ); Fri, 19 Oct 2012 09:12:23 -0400 Date: Fri, 19 Oct 2012 09:00:11 -0400 From: Konrad Rzeszutek Wilk To: David Vrabel , FlorianSchandinat@gmx.de Cc: xen-devel@lists.xen.org, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, Florian Tobias Schandinat Subject: Re: [PATCH 4/5] xen-fbfront: handle backend CLOSED without CLOSING Message-ID: <20121019130011.GD26830@phenom.dumpdata.com> References: <507FD39F.4060601@citrix.com> <1350554618-14582-4-git-send-email-david.vrabel@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1350554618-14582-4-git-send-email-david.vrabel@citrix.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: acsinet21.oracle.com [141.146.126.237] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1860 Lines: 55 On Thu, Oct 18, 2012 at 11:03:37AM +0100, David Vrabel wrote: > From: David Vrabel > > Backend drivers shouldn't transistion to CLOSED unless the frontend is > CLOSED. If a backend does transition to CLOSED too soon then the > frontend may not see the CLOSING state and will not properly shutdown. > > So, treat an unexpected backend CLOSED state the same as CLOSING. > > Signed-off-by: David Vrabel > Acked-by: Konrad Rzeszutek Wilk > --- > Cc: linux-fbdev@vger.kernel.org > Cc: Florian Tobias Schandinat Hey Florian, Should I prep a git pull for you with this or would it be OK if I just have your Ack to put this in my git pull for Linus? Thanks! > --- > drivers/video/xen-fbfront.c | 5 ++++- > 1 files changed, 4 insertions(+), 1 deletions(-) > > diff --git a/drivers/video/xen-fbfront.c b/drivers/video/xen-fbfront.c > index b7f5173..917bb56 100644 > --- a/drivers/video/xen-fbfront.c > +++ b/drivers/video/xen-fbfront.c > @@ -641,7 +641,6 @@ static void xenfb_backend_changed(struct xenbus_device *dev, > case XenbusStateReconfiguring: > case XenbusStateReconfigured: > case XenbusStateUnknown: > - case XenbusStateClosed: > break; > > case XenbusStateInitWait: > @@ -670,6 +669,10 @@ InitWait: > info->feature_resize = val; > break; > > + case XenbusStateClosed: > + if (dev->state == XenbusStateClosed) > + break; > + /* Missed the backend's CLOSING state -- fallthrough */ > case XenbusStateClosing: > xenbus_frontend_closed(dev); > break; > -- > 1.7.2.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/