Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933013Ab2JSP6z (ORCPT ); Fri, 19 Oct 2012 11:58:55 -0400 Received: from mail-la0-f46.google.com ([209.85.215.46]:62086 "EHLO mail-la0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759300Ab2JSP6x (ORCPT ); Fri, 19 Oct 2012 11:58:53 -0400 MIME-Version: 1.0 In-Reply-To: <20121019155300.GD980@krava.brq.redhat.com> References: <1350658326-14715-1-git-send-email-eranian@google.com> <1350658326-14715-2-git-send-email-eranian@google.com> <1350659619.2768.30.camel@twins> <20121019152337.GC980@krava.brq.redhat.com> <20121019155300.GD980@krava.brq.redhat.com> Date: Fri, 19 Oct 2012 17:58:52 +0200 Message-ID: Subject: Re: [PATCH 1/2] perf tools: add event modifier to request exclusive PMU access From: Stephane Eranian To: Jiri Olsa Cc: Peter Zijlstra , LKML , "mingo@elte.hu" , "ak@linux.intel.com" , Arnaldo Carvalho de Melo Content-Type: text/plain; charset=UTF-8 X-System-Of-Record: true Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1805 Lines: 46 On Fri, Oct 19, 2012 at 5:53 PM, Jiri Olsa wrote: > On Fri, Oct 19, 2012 at 05:47:11PM +0200, Stephane Eranian wrote: >> On Fri, Oct 19, 2012 at 5:23 PM, Jiri Olsa wrote: >> > On Fri, Oct 19, 2012 at 05:17:57PM +0200, Stephane Eranian wrote: >> >> On Fri, Oct 19, 2012 at 5:13 PM, Peter Zijlstra wrote: >> >> > On Fri, 2012-10-19 at 16:52 +0200, Stephane Eranian wrote: >> >> >> -modifier_event [ukhpGH]{1,8} >> >> >> +modifier_event [ukhpGHx]{1,8} >> >> > >> >> > wouldn't the max modifier sting length grow by adding another possible >> >> > modifier? >> >> >> >> That's what I thought too, but then I don't understand why it was at >> >> eight before and not >> >> seven: One instance of each letter, + a second for pp (precise=2). Or >> >> am I missing >> >> something here? >> > >> > hm, I think I assumed for some reason that 'ppp' is valid as well >> > >> If that's the case, then yes, I need to bump that number to 9. > > found my source ;) > > include/linux/perf_event.h: > ... > > /* > * precise_ip: > * > * 0 - SAMPLE_IP can have arbitrary skid > * 1 - SAMPLE_IP must have constant skid > * 2 - SAMPLE_IP requested to have 0 skid > * 3 - SAMPLE_IP must have 0 skid > * > * See also PERF_RECORD_MISC_EXACT_IP > */ > precise_ip : 2, /* skid constraint */ > ... > Ok, nobody supports 3 today, but that's fine. I can change that value to 9 then. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/