Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759065Ab2JSSB4 (ORCPT ); Fri, 19 Oct 2012 14:01:56 -0400 Received: from mail-bk0-f46.google.com ([209.85.214.46]:49086 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757130Ab2JSSBy (ORCPT ); Fri, 19 Oct 2012 14:01:54 -0400 MIME-Version: 1.0 In-Reply-To: <20121019173029.GO2616@ZenIV.linux.org.uk> References: <20121016223508.GR2616@ZenIV.linux.org.uk> <20121019154901.GK2616@ZenIV.linux.org.uk> <3908561D78D1C84285E8C5FCA982C28F19D57A82@ORSMSX108.amr.corp.intel.com> <20121019173029.GO2616@ZenIV.linux.org.uk> Date: Fri, 19 Oct 2012 11:01:53 -0700 Message-ID: Subject: Re: new execve/kernel_thread design From: Tony Luck To: Al Viro Cc: "linux-kernel@vger.kernel.org" , "linux-arch@vger.kernel.org" , Linus Torvalds , Catalin Marinas , Haavard Skinnemoen , Mike Frysinger , Jesper Nilsson , David Howells , Benjamin Herrenschmidt , Hirokazu Takata , Geert Uytterhoeven , Michal Simek , Jonas Bonn , "James E.J. Bottomley" , Richard Kuo , Martin Schwidefsky , Lennox Wu , "David S. Miller" , Paul Mundt , Chris Zankel , Chris Metcalf , Yoshinori Sato , Guan Xuetao Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 615 Lines: 15 On Fri, Oct 19, 2012 at 10:30 AM, Al Viro wrote: > IIRC, the lack of comments on function with unusual calling conventions was > the last remaining issue... Stylistically other asm functions have huge block header comments detailing register usage. But typically those are way more complex. I think your inline comments work fine here. -Tony -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/