Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933121Ab2JSWNI (ORCPT ); Fri, 19 Oct 2012 18:13:08 -0400 Received: from shadbolt.e.decadent.org.uk ([88.96.1.126]:41392 "EHLO shadbolt.e.decadent.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933087Ab2JSWNG (ORCPT ); Fri, 19 Oct 2012 18:13:06 -0400 Date: Fri, 19 Oct 2012 23:13:01 +0100 From: Ben Hutchings To: Stanislav Kinsbursky , Trond Myklebust Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, stable@vger.kernel.org, alan@lxorguk.ukuu.org.uk Message-ID: <20121019221301.GD13292@decadent.org.uk> References: <20121019024350.087156547@linuxfoundation.org> <20121019024351.583490752@linuxfoundation.org> <20121019221030.GC13292@decadent.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20121019221030.GC13292@decadent.org.uk> User-Agent: Mutt/1.5.20 (2009-06-14) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: ben@decadent.org.uk Subject: Re: [ 09/76] lockd: use rpc clients cl_nodename for id encoding X-SA-Exim-Version: 4.2.1 (built Mon, 22 Mar 2010 06:51:10 +0000) X-SA-Exim-Scanned: Yes (on shadbolt.decadent.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1460 Lines: 39 On Fri, Oct 19, 2012 at 11:10:30PM +0100, Ben Hutchings wrote: > On Thu, Oct 18, 2012 at 07:46:33PM -0700, Greg Kroah-Hartman wrote: > > 3.6-stable review patch. If anyone has any objections, please let me know. > > > > ------------------ > > > > From: Stanislav Kinsbursky > > > > commit 303a7ce92064c285a04c870f2dc0192fdb2968cb upstream. > > > > Taking hostname from uts namespace if not safe, because this cuold be > > performind during umount operation on child reaper death. And in this case > > current->nsproxy is NULL already. [...] > > struct nsm_res { > > @@ -141,6 +142,7 @@ static int nsm_mon_unmon(struct nsm_hand > > .vers = 3, > > .proc = NLMPROC_NSM_NOTIFY, > > .mon_name = nsm->sm_mon_name, > > + .nodename = utsname()->nodename, > > Can we be sure that this string pointer will remain valid at the point > where current->nsproxy has become NULL? Or should nsm_args::nodename > actually be a copy of the string? [...] Never mind, the following patch seems to deal with that. Ben. -- Ben Hutchings We get into the habit of living before acquiring the habit of thinking. - Albert Camus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/