Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755237Ab2JSWhn (ORCPT ); Fri, 19 Oct 2012 18:37:43 -0400 Received: from server.prisktech.co.nz ([115.188.14.127]:63491 "EHLO server.prisktech.co.nz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752441Ab2JSWhm (ORCPT ); Fri, 19 Oct 2012 18:37:42 -0400 Message-ID: <1350686261.17901.1.camel@gitbox> Subject: Re: [PATCH 1/3] ARM: dts: Update board files for pwm support From: Tony Prisk To: Thierry Reding Cc: arm@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree-discuss@lists.ozlabs.org Date: Sat, 20 Oct 2012 11:37:41 +1300 In-Reply-To: <1350643135-13197-1-git-send-email-linux@prisktech.co.nz> References: <1350643135-13197-1-git-send-email-linux@prisktech.co.nz> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 5754 Lines: 215 On Fri, 2012-10-19 at 23:38 +1300, Tony Prisk wrote: > This patch adds pwm support to arch-vt8500 board files, and adds > the use-case of pwm-backlight. > > Signed-off-by: Tony Prisk > --- > arch/arm/boot/dts/vt8500-bv07.dts | 8 ++++++++ > arch/arm/boot/dts/vt8500.dtsi | 29 +++++++++++++++++++++++++++++ > arch/arm/boot/dts/wm8505-ref.dts | 8 ++++++++ > arch/arm/boot/dts/wm8505.dtsi | 29 +++++++++++++++++++++++++++++ > arch/arm/boot/dts/wm8650-mid.dts | 8 ++++++++ > arch/arm/boot/dts/wm8650.dtsi | 17 +++++++++++++---- > 6 files changed, 95 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/boot/dts/vt8500-bv07.dts b/arch/arm/boot/dts/vt8500-bv07.dts > index 567cf4e..3cba367 100644 > --- a/arch/arm/boot/dts/vt8500-bv07.dts > +++ b/arch/arm/boot/dts/vt8500-bv07.dts > @@ -33,4 +33,12 @@ > }; > }; > }; > + > + backlight { > + compatible = "pwm-backlight"; > + pwms = <&pwm 0 50000>; > + > + brightness-levels = <0 4 8 16 32 64 128 255>; > + default-brightness-level = <5>; > + }; > }; > diff --git a/arch/arm/boot/dts/vt8500.dtsi b/arch/arm/boot/dts/vt8500.dtsi > index d8645e9..e196b2e 100644 > --- a/arch/arm/boot/dts/vt8500.dtsi > +++ b/arch/arm/boot/dts/vt8500.dtsi > @@ -40,14 +40,43 @@ > #address-cells = <1>; > #size-cells = <0>; > > + ref25: ref25M { > + #clock-cells = <0>; > + compatible = "fixed-clock"; > + clock-frequency = <25000000>; > + }; > + > ref24: ref24M { > #clock-cells = <0>; > compatible = "fixed-clock"; > clock-frequency = <24000000>; > }; > + > + pllb: pllb { > + #clock-cells = <0>; > + compatible = "via,vt8500-pll-clock"; > + clocks = <&ref25>; > + reg = <0x204>; > + }; > + > + clkpwm: pwm { > + #clock-cells = <0>; > + compatible = "via,vt8500-device-clock"; > + clocks = <&pllb>; > + divisor-reg = <0x348>; > + enable-reg = <0x250>; > + enable-bit = <14>; > + }; > }; > }; > > + pwm: pwm@d8220000 { > + #pwm-cells = <2>; > + compatible = "via,vt8500-pwm"; > + reg = <0xd8220000 0x100>; > + clocks = <&clkpwm>; > + }; > + > timer@d8130100 { > compatible = "via,vt8500-timer"; > reg = <0xd8130100 0x28>; > diff --git a/arch/arm/boot/dts/wm8505-ref.dts b/arch/arm/boot/dts/wm8505-ref.dts > index fd4e248..f51c0ed 100644 > --- a/arch/arm/boot/dts/wm8505-ref.dts > +++ b/arch/arm/boot/dts/wm8505-ref.dts > @@ -33,4 +33,12 @@ > }; > }; > }; > + > + backlight { > + compatible = "pwm-backlight"; > + pwms = <&pwm 0 50000>; > + > + brightness-levels = <0 4 8 16 32 64 128 255>; > + default-brightness-level = <5>; > + }; > }; > diff --git a/arch/arm/boot/dts/wm8505.dtsi b/arch/arm/boot/dts/wm8505.dtsi > index b459691..83c8ec5 100644 > --- a/arch/arm/boot/dts/wm8505.dtsi > +++ b/arch/arm/boot/dts/wm8505.dtsi > @@ -54,14 +54,43 @@ > #address-cells = <1>; > #size-cells = <0>; > > + ref25: ref25M { > + #clock-cells = <0>; > + compatible = "fixed-clock"; > + clock-frequency = <25000000>; > + }; > + > ref24: ref24M { > #clock-cells = <0>; > compatible = "fixed-clock"; > clock-frequency = <24000000>; > }; > + > + pllb: pllb { > + #clock-cells = <0>; > + compatible = "via,vt8500-pll-clock"; > + clocks = <&ref25>; > + reg = <0x204>; > + }; > + > + clkpwm: pwm { > + #clock-cells = <0>; > + compatible = "via,vt8500-device-clock"; > + clocks = <&pllb>; > + divisor-reg = <0x348>; > + enable-reg = <0x250>; > + enable-bit = <10>; > + }; > }; > }; > > + pwm: pwm@d8220000 { > + #pwm-cells = <2>; > + compatible = "via,vt8500-pwm"; > + reg = <0xd8220000 0x100>; > + clocks = <&clkpwm>; > + }; > + > timer@d8130100 { > compatible = "via,vt8500-timer"; > reg = <0xd8130100 0x28>; > diff --git a/arch/arm/boot/dts/wm8650-mid.dts b/arch/arm/boot/dts/wm8650-mid.dts > index cefd938..7a05dd5 100644 > --- a/arch/arm/boot/dts/wm8650-mid.dts > +++ b/arch/arm/boot/dts/wm8650-mid.dts > @@ -33,4 +33,12 @@ > }; > }; > }; > + > + backlight { > + compatible = "pwm-backlight"; > + pwms = <&pwm 0 50000>; > + > + brightness-levels = <0 4 8 16 32 64 128 255>; > + default-brightness-level = <5>; > + }; > }; > diff --git a/arch/arm/boot/dts/wm8650.dtsi b/arch/arm/boot/dts/wm8650.dtsi > index 83b9467..a25d240 100644 > --- a/arch/arm/boot/dts/wm8650.dtsi > +++ b/arch/arm/boot/dts/wm8650.dtsi > @@ -75,14 +75,16 @@ > reg = <0x204>; > }; > > - arm: arm { > + clkpwm: pwm { > #clock-cells = <0>; > compatible = "via,vt8500-device-clock"; > - clocks = <&plla>; > - divisor-reg = <0x300>; > + clocks = <&pllb>; > + divisor-reg = <0x348>; > + enable-reg = <0x250>; > + enable-bit = <10>; > }; > > - sdhc: sdhc { > + clksdhc: sdhc { > #clock-cells = <0>; > compatible = "via,vt8500-device-clock"; > clocks = <&pllb>; > @@ -94,6 +96,13 @@ > }; > }; > > + pwm: pwm@d8220000 { > + #pwm-cells = <2>; > + compatible = "via,vt8500-pwm"; > + reg = <0xd8220000 0x100>; > + clocks = <&clkpwm>; > + }; > + > timer@d8130100 { > compatible = "via,vt8500-timer"; > reg = <0xd8130100 0x28>; Please don't pull Patch 1/3 to any trees. I will include in a pull-request for arm-soc with other dts updates later on. Patch 2/3 + 3/3 can be taken now or Ack'd and I'll do a pull-request later. Regards Tony P -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/