Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751739Ab2JUGUE (ORCPT ); Sun, 21 Oct 2012 02:20:04 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:60007 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751457Ab2JUGUC (ORCPT ); Sun, 21 Oct 2012 02:20:02 -0400 Date: Sat, 20 Oct 2012 23:19:57 -0700 From: Dmitry Torokhov To: Arve =?iso-8859-1?B?SGr4bm5lduVn?= Cc: Mathieu Poirier , akpm@linux-foundation.org, linux-kernel@vger.kernel.org, rdunlap@xenotime.net, kernel-team@android.com, john.stultz@linaro.org, alan@lxorguk.ukuu.org.uk Subject: Re: [PATCH] drivers/tty: Folding Android's keyreset driver in sysRQ Message-ID: <20121021061957.GA25464@core.coreip.homeip.net> References: <1349459969-17473-1-git-send-email-mathieu.poirier@linaro.org> <20121005181608.GA24356@core.coreip.homeip.net> <506F3987.9020902@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1849 Lines: 46 On Tue, Oct 16, 2012 at 08:35:56PM -0700, Arve Hj?nnev?g wrote: > On Fri, Oct 5, 2012 at 12:48 PM, Mathieu Poirier > wrote: > > On 12-10-05 12:16 PM, Dmitry Torokhov wrote: > >> On Fri, Oct 05, 2012 at 11:59:29AM -0600, mathieu.poirier@linaro.org wrote: > >>> From: "Mathieu J. Poirier" > >>> > >>> Andrew, > >>> > >>> After requesting a number of changes that, to my understanding > >>> have been implemented, I have not been able to get the attention > >>> of the subsystem maintainer on this patch. > >>> > >>> If there are still issues, I'm open to making changes but I want > >>> to make sure it doesn't get forgotten. If there no objections, > >>> would you consider queuint it ? > >> > >> Mathieu, > >> > >> I have the same objection as before: using platform device solely for > >> the purpose of passing some data from board code to the driver. Surely > >> there are other ways of passing this bit of data... What about, for > >> example, making it an empty weak symbol so that board code could > >> override it with strong one? > > > > Thanks for the comments - I will implement a weak function in the > > keyreset driver. > > > > A weak symbol does not work. A single kernel can support multiple > devices that have unique reset key combinations. Such kernels will surely require device tree and I think everyone have already agreed that DT is the proper way of supplying this data on newer boards. So the weak symbol is for legacy boards that do not export device tree data and thus require per-board kernels. Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/