Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932785Ab2JVBZH (ORCPT ); Sun, 21 Oct 2012 21:25:07 -0400 Received: from ozlabs.org ([203.10.76.45]:48152 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932729Ab2JVBZE (ORCPT ); Sun, 21 Oct 2012 21:25:04 -0400 From: Rusty Russell To: Linus Torvalds Cc: David Miller , David Howells , Linux Kernel Mailing List Subject: Re: RFC: sign the modules at install time In-Reply-To: References: <87txtso9xw.fsf@rustcorp.com.au> <871ugwny1n.fsf@rustcorp.com.au> <87fw5bp858.fsf@rustcorp.com.au> User-Agent: Notmuch/0.14 (http://notmuchmail.org) Emacs/23.4.1 (i686-pc-linux-gnu) Date: Mon, 22 Oct 2012 10:58:11 +1030 Message-ID: <877gqjjqp0.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1013 Lines: 25 Linus Torvalds writes: > On Fri, Oct 19, 2012 at 12:58 PM, Linus Torvalds > wrote: >> >> Tssk. I fixed it up, and now it works-for-me(tm), but some perl person >> probably really should try to make that sign-file and x509keyid merge. >> My fix made the thing even slower, doing two extra "wc -c" invocations >> since it can't do "${#..}" expansion due to the locale problem. > > Hmm. I haven't seen this breakage personally yet, but looking more at > Rusty's last changes I'm pretty sure my fixes are potentially not > sufficient. Sorry for posting untested hack :( Thanks for the rewrite David; modules_install here was 18.6 seconds, became 19.1 with my broken hack, now 17.3 seconds. Cheers, Rusty. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/