MIME-Version: 1.0
In-Reply-To: <20121016152153.GD6807@ghostprotocols.net>
References: <1350344020-8071-1-git-send-email-irina.tirdea@gmail.com>
 <1350344020-8071-4-git-send-email-irina.tirdea@gmail.com> <20121016152153.GD6807@ghostprotocols.net>
From: Irina Tirdea <irina.tirdea@gmail.com>
Date: Mon, 22 Oct 2012 12:06:08 +0300
Message-ID: <CANg8OWLMvYgTnQjNL+pNgGqi9fJzEMDAuaR6qD=SdqPKxQJrBg@mail.gmail.com>
Subject: Re: [PATCH v4 3/6] perf tools: add --addr2line command line option
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Ingo Molnar <mingo@kernel.org>, Steven Rostedt <rostedt@goodmis.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        LKML <linux-kernel@vger.kernel.org>, Paul Mackerras <paulus@samba.org>,
        David Ahern <dsahern@gmail.com>, Namhyung Kim <namhyung@kernel.org>,
        Pekka Enberg <penberg@kernel.org>, Jiri Olsa <jolsa@redhat.com>,
        Irina Tirdea <irina.tirdea@intel.com>
Content-Type: text/plain; charset=ISO-8859-1
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1188
Lines: 40

On Tue, Oct 16, 2012 at 6:21 PM, Arnaldo Carvalho de Melo
<acme@ghostprotocols.net> wrote:
> Em Tue, Oct 16, 2012 at 02:33:37AM +0300, Irina Tirdea escreveu:
>> From: Irina Tirdea <irina.tirdea@intel.com>
>>
>> When analyzing data recorded on a target with a different architecture
>> than the host, we must use addr2line from the toolchain for that
>> architecture.
>>
>> Add a command line option to allow setting addr2line at runtime.
>
> You're doing two things here:
>
> 1. Adding --addr2line
>
> 2. fixing a bug for unresolved symbols
>
> Please try not to do that, instead provide two patches, one addressing
> each issue.
>

You're absolutely right. Missed this.

> Furthermore, Namhyung fixed #2 already:
>
> commit a2c1311c4cbd47a087e95be18fee79ead3d0744b
> Author: Namhyung Kim <namhyung.kim@lge.com>
> Date:   Mon Oct 15 12:39:42 2012 +0900
>
>     perf tools: Fix segfault when using srcline sort key
>
> - Arnaldo

Thanks,
Irina
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/