Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753935Ab2JVMHy (ORCPT ); Mon, 22 Oct 2012 08:07:54 -0400 Received: from mx2.parallels.com ([64.131.90.16]:39375 "EHLO mx2.parallels.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752477Ab2JVMHx (ORCPT ); Mon, 22 Oct 2012 08:07:53 -0400 Message-ID: <5085370F.80204@parallels.com> Date: Mon, 22 Oct 2012 16:07:43 +0400 From: Glauber Costa User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121016 Thunderbird/16.0.1 MIME-Version: 1.0 To: Ezequiel Garcia CC: , , Tim Bird , Christoph Lameter , Pekka Enberg , Matt Mackall Subject: Re: [PATCH 2/2] mm/slob: Use free_page instead of put_page for page-size kmalloc allocations References: <1350907471-2236-1-git-send-email-elezegarcia@gmail.com> In-Reply-To: <1350907471-2236-1-git-send-email-elezegarcia@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 772 Lines: 18 On 10/22/2012 04:04 PM, Ezequiel Garcia wrote: > When freeing objects, the slob allocator currently free empty pages > calling __free_pages(). However, page-size kmallocs are disposed > using put_page() instead. > > It makes no sense to call put_page() for kernel pages that are provided > by the object allocator, so we shouldn't be doing this ourselves. > > This is based on: > commit d9b7f22623b5fa9cc189581dcdfb2ac605933bf4 > Author: Glauber Costa Acked-by: Glauber Costa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/