MIME-Version: 1.0
In-Reply-To: <50831CA3.2020602@linaro.org>
References: <507FBC20.50004@linaro.org>
	<1350683446-8244-1-git-send-email-jwerner@chromium.org>
	<50831CA3.2020602@linaro.org>
Date: Mon, 22 Oct 2012 10:13:01 -0700
Message-ID: <CAODwPW-bnECEawh9sOwhydDodD+J4x2s4f5uHpeLusuBx-itxw@mail.gmail.com>
Subject: Re: [PATCH] acpi/cpuidle: reinitialize power_usage values when
 adding/removing C-states
From: Julius Werner <jwerner@chromium.org>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: linux-kernel@vger.kernel.org, len.brown@intel.com, khilman@ti.com,
        rjw@sisk.pl, deepthi@linux.vnet.ibm.com, akpm@linux-foundation.org,
        Trinabh Gupta <g.trinabh@gmail.com>, snanda@chromium.org,
        Lists Linaro-dev <linaro-dev@lists.linaro.org>
Content-Type: text/plain; charset=ISO-8859-1
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1122
Lines: 24

> Could we just say this is always true because state[i+1] consumes less
> than state[i] ?
>
> And then just remove the 'set_power_state' function, and the field
> 'driver->power_specified' ?
>
> That will cleanup the code and fix this problem, no ?

I totally agree with your analysis. Even if a driver were to set
proper usage values (and the power_specified bit), none of the
existing governors would care about those actual numbers (and since
the vast majority of drivers uses fake values anyway, this is not
likely to change in the future). This seems to be a classic example of
unnecessary over-engineering.

I am mostly interested in getting that bug fixed right now, but
removing unnecessary code is always a good thing. If you think it
would have a good chance of getting merged, I would be happy to draft
up a larger patch that refactors power_usage away completely.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/