Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932367Ab2JVWex (ORCPT ); Mon, 22 Oct 2012 18:34:53 -0400 Received: from ogre.sisk.pl ([193.178.161.156]:59098 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932319Ab2JVWew (ORCPT ); Mon, 22 Oct 2012 18:34:52 -0400 From: "Rafael J. Wysocki" To: Bryan Wu Cc: Linus Walleij , Miles Lane , akpm , Linux LED Subsystem , lkml Subject: Re: [PATCH] ledtrig-cpu: use spin_lock to replace mutex lock Date: Tue, 23 Oct 2012 00:38:44 +0200 Message-ID: <2097144.LhjfvZ65DK@vostro.rjw.lan> User-Agent: KMail/4.8.5 (Linux/3.6.2-6-desktop; KDE/4.8.5; x86_64; ; ) In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1593 Lines: 52 On Monday 22 of October 2012 11:59:19 Bryan Wu wrote: > Hiya, > > Can I get some Acked or Tested-by from Rafael or Miles before I put it > in my linux-leds tree? Well, I just explained why the current code didn't work. :-) Anyway, please feel free to add Acked-by: Rafael J. Wysocki to the patch (assuming that the performance impact is negligible). Thanks, Rafael > On Thu, Oct 18, 2012 at 12:34 PM, Bryan Wu wrote: > > On Thu, Oct 18, 2012 at 11:35 AM, Linus Walleij > > wrote: > >> On Thu, Oct 18, 2012 at 8:18 PM, Bryan Wu wrote: > >> > >>> Mutex lock is not safe in atomic context like the bug reported by > >>> Miles Lane: > >> (...) > >>> This patch replace mutex lock with spin lock which is safe for this case. > >>> > >>> Reported-by: Miles Lane > >>> Reported-by: Rafael J. Wysocki > >>> Cc: Linus Walleij > >>> Signed-off-by: Bryan Wu > >> > >> Looks correct to me: > >> Acked-by: Linus Walleij > >> > > > > Thanks, Linus. > > > > Miles, could you please help to try this patch on your testing system? > > I really appreciate it. > > > > -Bryan > -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/