Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754983Ab2JVXQV (ORCPT ); Mon, 22 Oct 2012 19:16:21 -0400 Received: from mail-ee0-f46.google.com ([74.125.83.46]:40676 "EHLO mail-ee0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751778Ab2JVXQU (ORCPT ); Mon, 22 Oct 2012 19:16:20 -0400 MIME-Version: 1.0 In-Reply-To: <2097144.LhjfvZ65DK@vostro.rjw.lan> References: <2097144.LhjfvZ65DK@vostro.rjw.lan> From: Bryan Wu Date: Mon, 22 Oct 2012 16:15:58 -0700 Message-ID: Subject: Re: [PATCH] ledtrig-cpu: use spin_lock to replace mutex lock To: "Rafael J. Wysocki" Cc: Linus Walleij , Miles Lane , akpm , Linux LED Subsystem , lkml Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1844 Lines: 56 On Mon, Oct 22, 2012 at 3:38 PM, Rafael J. Wysocki wrote: > On Monday 22 of October 2012 11:59:19 Bryan Wu wrote: >> Hiya, >> >> Can I get some Acked or Tested-by from Rafael or Miles before I put it >> in my linux-leds tree? > > Well, I just explained why the current code didn't work. :-) > > Anyway, please feel free to add > > Acked-by: Rafael J. Wysocki > I was just reminded by Nathan Lynch most of led-trigger API like register/unregister/event are potentially sleep. They should not be used in atomic context. Any suggestion to fix it? Thanks, -Bryan > >> On Thu, Oct 18, 2012 at 12:34 PM, Bryan Wu wrote: >> > On Thu, Oct 18, 2012 at 11:35 AM, Linus Walleij >> > wrote: >> >> On Thu, Oct 18, 2012 at 8:18 PM, Bryan Wu wrote: >> >> >> >>> Mutex lock is not safe in atomic context like the bug reported by >> >>> Miles Lane: >> >> (...) >> >>> This patch replace mutex lock with spin lock which is safe for this case. >> >>> >> >>> Reported-by: Miles Lane >> >>> Reported-by: Rafael J. Wysocki >> >>> Cc: Linus Walleij >> >>> Signed-off-by: Bryan Wu >> >> >> >> Looks correct to me: >> >> Acked-by: Linus Walleij >> >> >> > >> > Thanks, Linus. >> > >> > Miles, could you please help to try this patch on your testing system? >> > I really appreciate it. >> > >> > -Bryan >> > -- > I speak only for myself. > Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/