Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932410Ab2JVX4F (ORCPT ); Mon, 22 Oct 2012 19:56:05 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:43518 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932294Ab2JVX4E (ORCPT ); Mon, 22 Oct 2012 19:56:04 -0400 Date: Mon, 22 Oct 2012 16:56:02 -0700 From: Andrew Morton To: Jiri Kosina Cc: Stefani Seibold , richard -rw- weinberger , Wei Yang , linux-kernel@vger.kernel.org Subject: Re: [PATCH] remove untouched code in kfifo_in Message-Id: <20121022165602.41c4953e.akpm@linux-foundation.org> In-Reply-To: References: <1350568765-5723-1-git-send-email-weiyang@linux.vnet.ibm.com> <1350624189.14741.1.camel@wall-e> X-Mailer: Sylpheed 3.0.2 (GTK+ 2.20.1; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1036 Lines: 27 On Fri, 19 Oct 2012 09:34:43 +0200 (CEST) Jiri Kosina wrote: > On Fri, 19 Oct 2012, Stefani Seibold wrote: > > > > > In kfifo_in marco, one piece of code is arounded by if(0). This code in > > > > introduced by Stefani Seibold to suppress a compiler > > > > warning. This warning is not there with the upgrade of gcc version. > > > > > > > > This patch just remove this code. > > > > > > Are you sure? > > > This code fragment looks like a compiler bomb to detect type mismatch to me... > > > > Yes, you are great! That was the reason why i made this peace of code. > > So don't remove it! > > As even you, the author of the code, got confused by it for a while, > adding an explanatory comment seems appropriate. > include/linux/typecheck.h? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/