Return-Path: <linux-kernel-owner+willy=40w.ods.org@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id <S319127AbSIDLK3>; Wed, 4 Sep 2002 07:10:29 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org
	id <S319128AbSIDLK3>; Wed, 4 Sep 2002 07:10:29 -0400
Received: from fungus.teststation.com ([212.32.186.211]:47110 "EHLO
	fungus.teststation.com") by vger.kernel.org with ESMTP
	id <S319127AbSIDLK3>; Wed, 4 Sep 2002 07:10:29 -0400
Date: Wed, 4 Sep 2002 13:14:16 +0200 (CEST)
From: Urban Widmark <urban@teststation.com>
X-X-Sender: puw@cola.enlightnet.local
To: Panu Matilainen <pmatilai@welho.com>
cc: linux-kernel@vger.kernel.org
Subject: Re: 32bit UID wraps around with smbfs
In-Reply-To: <Pine.LNX.4.44.0209041115590.7970-100000@chip.ath.cx>
Message-ID: <Pine.LNX.4.44.0209041252590.7921-100000@cola.enlightnet.local>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1350
Lines: 36

On Wed, 4 Sep 2002, Panu Matilainen wrote:

> Hi,
> 
> Smbfs has problems with 32bit UID/GID's: when you do
> 'smbmount //some/share /mnt/samba -o uid=100000' the mountpoint UID (and 
> GID) wrap around at 65535.
> 
> The attached patch, along with samba recompile against fixed headers
> apparently fixes it. This problem is present at least in all 2.4 kernels,
> I haven't looked at 2.5.

I don't think this is an acceptable fix for the main kernel. You are
changing a binary interface in a stable kernel series.


I personally think that smb_mount_data is a bad idea and are slowly
working on moving smbfs to an ascii interface. With 2.4 any recent
smbmount should be using the ascii interface already, the problem there is
that smbmnt uses the smb_mount_data internally ...

This patch contains stuff I want to have included in samba 2.2.6,
including fixes for smbmnt's uid-abuse:
http://www.hojdpunkten.ac.se/054/samba/smbmount-2.2.5-misc-2.patch.gz

And this is needed to change the storage size of the in-kernel mount
struct:
http://www.hojdpunkten.ac.se/054/samba/smbfs-2.4.18-uid32.patch

/Urban

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/