Message-ID: <50862E02.6020002@intel.com>
Date: Tue, 23 Oct 2012 13:41:22 +0800
From: "Yan, Zheng" <zheng.z.yan@intel.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121016 Thunderbird/16.0.1
MIME-Version: 1.0
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
CC: linux-kernel@vger.kernel.org, eranian@google.com, ak@linux.intel.com
Subject: Re: [PATCH 1/6] perf, x86: Basic Haswell LBR call stack support
References: <1350886279-6141-1-git-send-email-zheng.z.yan@intel.com>  <1350886279-6141-2-git-send-email-zheng.z.yan@intel.com> <1350902138.2768.86.camel@twins>
In-Reply-To: <1350902138.2768.86.camel@twins>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1196
Lines: 27

On 10/22/2012 06:35 PM, Peter Zijlstra wrote:
> On Mon, 2012-10-22 at 14:11 +0800, Yan, Zheng wrote:
>> --- a/include/uapi/linux/perf_event.h
>> +++ b/include/uapi/linux/perf_event.h
>> @@ -160,8 +160,9 @@ enum perf_branch_sample_type {
>>         PERF_SAMPLE_BRANCH_ABORT        = 1U << 7, /* transaction aborts */
>>         PERF_SAMPLE_BRANCH_INTX         = 1U << 8, /* in transaction (flag) */
>>         PERF_SAMPLE_BRANCH_NOTX         = 1U << 9, /* not in transaction (flag) */
>> +       PERF_SAMPLE_BRANCH_CALL_STACK   = 1U << 10, /* call stack */
>>  
>> -       PERF_SAMPLE_BRANCH_MAX          = 1U << 10, /* non-ABI */
>> +       PERF_SAMPLE_BRANCH_MAX          = 1U << 11, /* non-ABI */
>>  }; 
> 
> You add an ABI sample type without mentioning it in your changelog.. I
> think I'll stop reading here.
> 
Ok, I will add the ABI change to the change log. Do you think we should hide this
branch sample type from user?

Regards
Yan, Zheng 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/