Date: Tue, 23 Oct 2012 10:34:30 +0400
From: Cyrill Gorcunov <gorcunov@openvz.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Pavel Emelyanov <xemul@parallels.com>, LKML <linux-kernel@vger.kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [rfc 0/2] Introducing VmFlags field into smaps output
Message-ID: <20121023063430.GB7020@moon>
References: <20121022191452.785366817@openvz.org>
 <20121022122934.d2e2fa57.akpm@linux-foundation.org>
 <5085B1A8.4020609@parallels.com>
 <20121022205641.GL2303@moon>
 <20121022213449.GH31440@moon>
 <20121022145158.53bddfc1.akpm@linux-foundation.org>
 <20121023061341.GA7020@moon>
 <20121022233025.09ec2d92.akpm@linux-foundation.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20121022233025.09ec2d92.akpm@linux-foundation.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1005
Lines: 34

On Mon, Oct 22, 2012 at 11:30:25PM -0700, Andrew Morton wrote:
...
> > Yup, but not only that, this kind of trick hides associativity between
> > VM_ constant and mnemonic, so on changes one would have to figure out
> > which position some flag has in this foo[] array, so I vote for not
> > use it :-)
> 
> Well you could do
> 
> struct {
> 	char x[2];
> } y[] = {
> 	[CLOG2(VM_DONTEXPAND)] =	{ 'd', 'e' },
> 	[CLOG2(VM_ACCOUNT)] =		{ 'a', 'c' },
> 	[CLOG2(VM_NORESERVE)] =		{ 'n', 'r' },
> };
> 
> 	...
> 
> 	for (i = 0; i < BITS_PER_LONG; i++) {
> 		if (flags & (1 << i))
> 			seq_printf("%c%c ", y[i][0], y[i][1]);
> 	}
> 
> where CLOG2() is extracted from the guts of ilog2().
> 
> I'll stop now :)

Yup, this one will be a wy better. Letme try it out :)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/