MIME-Version: 1.0
In-Reply-To: <009c01cdb0f2$812b5f90$83821eb0$%kim@samsung.com>
References: <001001cdb0c5$2ac96520$805c2f60$%kim@samsung.com>
	<001b01cdb0c6$67e386b0$37aa9410$%kim@samsung.com>
	<CANGUGtC+g22+ohn-QjK+ZQkeoZCk6gsDUn8S=c8jmkJ1tek1AQ@mail.gmail.com>
	<009c01cdb0f2$812b5f90$83821eb0$%kim@samsung.com>
Date: Tue, 23 Oct 2012 10:20:44 +0200
Message-ID: <CANGUGtBtgmWW1VjMP5mEK9qOzLxLUSgD_KvUr1b0+Yi3bHgVBQ@mail.gmail.com>
Subject: Re: [PATCH 11/16 v2] f2fs: add inode operations for special inodes
From: Marco Stornelli <marco.stornelli@gmail.com>
To: Jaegeuk Kim <jaegeuk.kim@samsung.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        gregkh@linuxfoundation.org, viro@zeniv.linux.org.uk, arnd@arndb.de,
        tytso@mit.edu, chur.lee@samsung.com, cm224.lee@samsung.com,
        jooyoung.hwang@samsung.com
Content-Type: text/plain; charset=ISO-8859-1
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 4019
Lines: 121

2012/10/23 Jaegeuk Kim <jaegeuk.kim@samsung.com>:
>
>> -----Original Message-----
>> From: Marco Stornelli [mailto:marco.stornelli@gmail.com]
>> Sent: Tuesday, October 23, 2012 4:02 PM
>> To: Jaegeuk Kim
>> Cc: linux-fsdevel@vger.kernel.org; linux-kernel@vger.kernel.org; gregkh@linuxfoundation.org;
>> viro@zeniv.linux.org.uk; arnd@arndb.de; tytso@mit.edu; chur.lee@samsung.com; cm224.lee@samsung.com;
>> jooyoung.hwang@samsung.com
>> Subject: Re: [PATCH 11/16 v2] f2fs: add inode operations for special inodes
>> Importance: High
>>
>> 2012/10/23 Jaegeuk Kim <jaegeuk.kim@samsung.com>:
>> > This adds inode operations for directory, symlink, and special inodes.
>> >
>> > Signed-off-by: Changman Lee <cm224.lee@samsung.com>
>> > Signed-off-by: Jaegeuk Kim <jaegeuk.kim@samsung.com>
>> > ---
>> >  fs/f2fs/namei.c |  494 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
>> >  1 file changed, 494 insertions(+)
>> >  create mode 100644 fs/f2fs/namei.c
>> >
>> > diff --git a/fs/f2fs/namei.c b/fs/f2fs/namei.c
>> > new file mode 100644
>> > index 0000000..899d144
>> > --- /dev/null
>> > +++ b/fs/f2fs/namei.c
>> > @@ -0,0 +1,494 @@
>> > +/**
>> > + * fs/f2fs/namei.c
>> > + *
>> > + * Copyright (c) 2012 Samsung Electronics Co., Ltd.
>> > + *             http://www.samsung.com/
>> > + *
>> > + * This program is free software; you can redistribute it and/or modify
>> > + * it under the terms of the GNU General Public License version 2 as
>> > + * published by the Free Software Foundation.
>> > + */
>> > +#include <linux/fs.h>
>> > +#include <linux/f2fs_fs.h>
>> > +#include <linux/pagemap.h>
>> > +#include <linux/sched.h>
>> > +#include <linux/ctype.h>
>> > +
>> > +#include "f2fs.h"
>> > +#include "xattr.h"
>> > +#include "acl.h"
>> > +
>> > +static struct inode *f2fs_new_inode(struct inode *dir, umode_t mode)
>> > +{
>> > +       struct super_block *sb = dir->i_sb;
>> > +       struct f2fs_sb_info *sbi = F2FS_SB(sb);
>> > +       nid_t ino;
>> > +       struct inode *inode;
>> > +       bool nid_free = false;
>> > +       int err;
>> > +
>> > +       inode = new_inode(sb);
>> > +       if (!inode)
>> > +               return ERR_PTR(-ENOMEM);
>> > +
>> > +       mutex_lock_op(sbi, NODE_NEW);
>> > +       if (!alloc_nid(sbi, &ino)) {
>> > +               mutex_unlock_op(sbi, NODE_NEW);
>> > +               err = -ENOSPC;
>> > +               goto fail;
>> > +       }
>> > +       mutex_unlock_op(sbi, NODE_NEW);
>> > +
>> > +       inode->i_uid = current_fsuid();
>> > +
>> > +       if (dir->i_mode & S_ISGID) {
>> > +               inode->i_gid = dir->i_gid;
>> > +               if (S_ISDIR(mode))
>> > +                       mode |= S_ISGID;
>> > +       } else {
>> > +               inode->i_gid = current_fsgid();
>> > +       }
>> > +
>> > +       inode->i_ino = ino;
>> > +       inode->i_mode = mode;
>> > +       inode->i_blocks = 0;
>> > +       inode->i_mtime = inode->i_atime = inode->i_ctime = CURRENT_TIME;
>> > +
>> > +       err = insert_inode_locked(inode);
>> > +       if (err) {
>> > +               err = -EINVAL;
>> > +               nid_free = true;
>> > +               goto out;
>> > +       }
>> > +
>> > +       mark_inode_dirty(inode);
>> > +       return inode;
>> > +
>> > +out:
>> > +       clear_nlink(inode);
>> > +       unlock_new_inode(inode);
>> > +fail:
>> > +       iput(inode);
>>
>> make_bad_inode here?
>
> I wanted to call f2fs_evict_inode() at this moment.
> - f2fs_evict_inode()
>  - remove_inode_page()
>    -> check any erroneous conditions.
>
> Got coffee? :)
>

Not yet, I'm reading my 240 email yet :)
I meant not to replace iput but to add make_bad_inode() before (I
don't know if it was clear). I don't know if it's the right thing to
do. In case of "out" I'd do the "rollback" here.

Marco
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/