Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756861Ab2JWIbt (ORCPT ); Tue, 23 Oct 2012 04:31:49 -0400 Received: from mail-wi0-f172.google.com ([209.85.212.172]:51428 "EHLO mail-wi0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753450Ab2JWIbq (ORCPT ); Tue, 23 Oct 2012 04:31:46 -0400 MIME-Version: 1.0 In-Reply-To: <5085A7CA.3070001@wwwdotorg.org> References: <1350659375-7335-1-git-send-email-linus.walleij@stericsson.com> <50817E43.8000804@wwwdotorg.org> <5085A7CA.3070001@wwwdotorg.org> Date: Tue, 23 Oct 2012 10:31:45 +0200 Message-ID: Subject: Re: [PATCH] pinctrl/nomadik: use irq_create_mapping() From: Linus Walleij To: Stephen Warren , Grant Likely , Rob Herring Cc: Linus Walleij , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Stephen Warren , Anmar Oueja , Lee Jones Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1134 Lines: 26 On Mon, Oct 22, 2012 at 10:08 PM, Stephen Warren wrote: > On 10/22/2012 02:14 AM, Linus Walleij wrote: >> It's an IRQ handler so it should be robust to spurious IRQs due to >> transient hardware states etc I believe. >> >> So if there is a transient IRQ before gpio_to_irq() is called -> boom. > > I wonder though (a) why it would be unmasked in HW, and (b) why the > software would even look at the status bit if no handler were registered? That's true of course ... OK I'll update the patch. Still I'm not feeling good about the irq_create_mapping/irq_find_mapping separation, I think a lot of drivers just get this wrong and it's causing bugs... it'd be way better if there was just one of them and we could count on descriptors being allocated after adding any kind of irqdomain but I have no clue how hard it would be to achieve this. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/